src_compressible_stag: always consume the spatialCrossVec header block on restart - #267
Merged
isriva merged 1 commit intoSep 22, 2026
Conversation
…k on restart WriteCheckPoint always emits the spatialCrossVec block into the header when plot_cross is set. ReadCheckPoint skipped *reading* it when reset_stats == 1 but did not skip *over* it in the stream, so the turbulent-forcing block that follows was parsed starting from the spatial-cross numbers. With plot_cross = 1, reset_stats = 1, turbForcing > 1 and turbRestartRun = 1 the first 264 accumulated correlation values were loaded as OU forcing amplitudes. Since nothing further is read from the header the stream never resynchronised and the failure was completely silent -- outcomes ranged from a harmless perturbation to an immediately unstable run. Consume the block unconditionally and discard it when resetting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WriteCheckPoint always emits the spatialCrossVec block into the header when
plot_cross is set. ReadCheckPoint skipped reading it when reset_stats == 1
but did not skip over it in the stream, so the turbulent-forcing block that
follows was parsed starting from the spatial-cross numbers.
With plot_cross = 1, reset_stats = 1, turbForcing > 1 and turbRestartRun = 1 the
first 264 accumulated correlation values were loaded as OU forcing amplitudes.
Since nothing further is read from the header the stream never resynchronised
and the failure was completely silent -- outcomes ranged from a harmless
perturbation to an immediately unstable run.
Consume the block unconditionally and discard it when resetting.