src_compressible_stag: reduce data_xcross across ranks in the all_correl branch - #266
Merged
Merged
Conversation
…rel branch evaluateStatsStag1D has two paths for gathering the cross-cell pencil data. The all_correl == 0 path reduces data_xcross across ranks before using it; the all_correl == 1 path did not. GetPencilCross assigns into the flat buffer only for cells where i == x_star, so each rank touches only the (j,k) slots of boxes it owns that contain that plane. Without the reduction every other rank saw zeros, and EvaluateSpatialCorrelations1D divides by those entries (1.0/cvcross, 1.0/(meanrhocross*meanrho)), producing inf/NaN rather than merely wrong numbers. The buffer was also constructed once outside the loop over the five x* values and never re-zeroed, so iterations 1-4 additionally inherited stale entries from the previous x*. Moving the declaration inside the loop fixes both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
evaluateStatsStag1D has two paths for gathering the cross-cell pencil data. The
all_correl == 0 path reduces data_xcross across ranks before using it; the
all_correl == 1 path did not.
GetPencilCross assigns into the flat buffer only for cells where i == x_star, so
each rank touches only the (j,k) slots of boxes it owns that contain that plane.
Without the reduction every other rank saw zeros, and
EvaluateSpatialCorrelations1D divides by those entries (1.0/cvcross,
1.0/(meanrhocross*meanrho)), producing inf/NaN rather than merely wrong numbers.
The buffer was also constructed once outside the loop over the five x* values
and never re-zeroed, so iterations 1-4 additionally inherited stale entries from
the previous x*. Moving the declaration inside the loop fixes both.