arm64: dts: aspeed: arthur: Update I2C8 and I2C12 - #311
Conversation
Add SCM_I2C<0> mux@70/71 nodes for P0/board VRs, clocks, temps, and ADCs in DTS. Add SCM_I2C<2> for fan controllers for Churro and 2U Fan Boards in DTS. Add aliases for BMC's I2C8 and I2C12 buses. Tested: - Kernel booted with the Updated DTS - Verified aliases working as expected Signed-off-by: ankprasa <ankprasa@amd.com>
modolaty
left a comment
modolaty
left a comment
There was a problem hiding this comment.
note you have 2 different controller
EMC2305 and NCT7363
That will break set-fan-spead.sh logic
| i2c103 = &arthur_fan_board_ch3; | ||
| i2c104 = &arthur_fan_board_ch2; | ||
| i2c105 = &arthur_fan_board_ch3; | ||
| i2c100 = &P0_conn_012_cpu; |
There was a problem hiding this comment.
i2c100 to i2c107 are not used
This will cause compile error
| i2c203 = &churro_fans_0_0; | ||
| i2c204 = &churro_fans_0_1; | ||
| i2c210 = &churro_id; | ||
| i2c215 = &arthur_2u_id; |
There was a problem hiding this comment.
arthur_2u_id is NOT used
remove it
| i2c210 = &churro_id; | ||
| i2c215 = &arthur_2u_id; | ||
| i2c211 = &churro_mcu; | ||
| i2c216 = &arthur_2u_mcu; |
There was a problem hiding this comment.
arthur_2u_mcu is NOT used
remove it
| fan@1 { | ||
| min-rpm = /bits/ 16 <1000>; | ||
| max-rpm = /bits/ 16 <16000>; | ||
| arthur_2u_mux: i2cswitch@76 { |
There was a problem hiding this comment.
This is the 1st Mux at 0x76
| fan@2 { | ||
| min-rpm = /bits/ 16 <1000>; | ||
| max-rpm = /bits/ 16 <16000>; | ||
| fan_board2_mux: i2cswitch@76 { |
There was a problem hiding this comment.
This is the 2nd Mux at 0x76
looks like they will collide
| reg = <0>; | ||
| #address-cells = <1>; | ||
| #size-cells = <0>; | ||
|
|
There was a problem hiding this comment.
Do we also want to add P0 SCM BRD ID at 0x54?
| }; | ||
| }; | ||
|
|
||
| P0_clk: i2c@1 { |
There was a problem hiding this comment.
This port is NC, so will need to remove.
| }; | ||
| }; | ||
|
|
||
| NC_1: i2c@3 { |
There was a problem hiding this comment.
For ports not connected, do we want to remove them so they aren't accessible?
| #address-cells = <1>; | ||
| #size-cells = <0>; | ||
|
|
||
| emc1438@4e { |
There was a problem hiding this comment.
Device is present, but driver isn't being bound for these 2 devices.
| #address-cells = <1>; | ||
| #size-cells = <0>; | ||
|
|
||
| pdb_vmon@54 { |
There was a problem hiding this comment.
Device is present, but driver isn't being bound for these 2 devices.
| #address-cells = <1>; | ||
| #size-cells = <0>; | ||
|
|
||
| brd_adc@48 { |
There was a problem hiding this comment.
Device is present, but driver isn't being bound.
| #address-cells = <1>; | ||
| #size-cells = <0>; | ||
| i2c-mux-idle-disconnect; | ||
|
|
There was a problem hiding this comment.
Any reason channels 0->5 aren't included? They are go to connectors with IO expanders.
| #address-cells = <1>; | ||
| #size-cells = <0>; | ||
| i2c-mux-idle-disconnect; | ||
|
|
There was a problem hiding this comment.
We need to add channel 4 back. This should have the clocks of P0_clk.
| #address-cells = <1>; | ||
| #size-cells = <0>; | ||
|
|
||
| i2cswitch@76 { |
There was a problem hiding this comment.
This needs changed to 0x75. Will need to test with latest board though.
| #address-cells = <1>; | ||
| #size-cells = <0>; | ||
|
|
||
| emc2305@4d { |
There was a problem hiding this comment.
Will need changed to have only a single fan.
| }; | ||
|
|
||
| /* TacoBowl ch3 -> second Churro/2U superset path */ | ||
| arthur_fan_board_ch3: i2c@3 { |
There was a problem hiding this comment.
What is this one for? How are the fan boards expected to be configured?
- Fan boards for both channel 2 and 3
- Fan board for either channel 2 or 3 but not both. (IE no assigned plug in spot, can do either)
3 participants
Add SCM_I2C<0> mux@70/71 nodes for P0/board VRs, clocks, temps, and ADCs in DTS. Add SCM_I2C<2> for fan controllers for Churro and 2U Fan Boards in DTS. Add aliases for BMC's I2C8 and I2C12 buses.
Tested: