Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(madara): preserve volume order for multi-volume chapter lists (v2.4.0)
Checklist
type(scope): description(e.g.feat(<generator>): add new source)Summary
Fixes inverted chapter order for multi-volume/multi-arc novels under the Madara multisrc generator (such as Foxaholic: Strange Grief Wants to Retire
The Weakest Hunter Dreams of a Hero).On WordPress Madara theme sites, volume containers (
li.parent.has-child) are rendered in ascending order (Volume 0: Short Story->Arc 1->Arc 2-> ... ->Arc 11), while chapters within each volume are rendered in descending order (newest first).Previously, flattening all
.wp-manga-chapterelements across the whole page into a single array and reversing it inverted the volume sequence itself (putting Arc 11 first and Short Stories / Arc 1 last).Evidence