Conversation
Signed-off-by: Sam Clark <dev28pins@icloud.com>
There was a problem hiding this comment.
Pull request overview
This PR introduces an embedded Arduino/Adafruit NeoPixel “serial light show” sketch with a configurable matrix mapping, interactive serial commands to edit per-frame LED colors/delays, and EEPROM persistence for saved shows.
Changes:
- Added
Matrix.hcontaining matrix dimensions, LED layout mapping (PROGMEM), and related compile-time configuration. - Added a serial command handler (
set,clr,dly,export,idx,mtx, etc.) plus frame render loop helpers. - Added helper utilities for undo/redo state swapping, matrix coordinate transforms, color-code conversion, and EEPROM save/load/clear.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 18 comments.
| File | Description |
|---|---|
| Matrix.h | Defines matrix geometry, LED counts, offset, and the PROGMEM index mapping used by coordinate-based commands. |
| LightShowCLI-Embedded.ino | Main sketch: initializes the NeoPixel strip + serial CLI and runs the frame playback loop. |
| LoopFuncs.ino | Implements frame rendering (colorLoop) and the serial CLI command parser/executor. |
| Helper.ino | Adds EEPROM persistence, undo/redo snapshotting, coordinate transforms, and color helpers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.