Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary scopes for comparisons and attribute/index updates inherited the surrounding frame's capture marker. A closure holding the parent therefore prevented unrelated temporary copies from returning to the frame pool. Exceptions could also bypass cleanup entirely. Repeated expressions eventually exhausted the CI memory budget.
Clear inherited capture identity on detached copies, retain and register genuine captures, and use a shared cleanup path on both normal return and failure. Add a workload that checks values, closure lifetime and original exceptions, plus a macOS/Linux CI check that verifies frame allocations remain bounded as the iteration count grows.
Validation so far:
TestHashOnly#test_broken_hash_valueexceeded the 2 GiB limit on maine45622a; the fix passes both assertions in 31.9 seconds with 269,344 KiB peak process-family RSS.