feat(browser-act): enable ecommerce packs - #113
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (11)
🚧 Files skipped from review as they are similar to previous changes (11)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughAdded nine ecommerce browser action manifests for general ecommerce, Goofish, and Taobao extraction flows. Added integration registration and unit tests that validate manifest fields, extraction scripts, and supported step operations. ChangesEcommerce browser action packs
Estimated code review effort: 2 (Simple) | ~15 minutes Merge Risk: ⚪ Minimal · up to This change adds executable e-commerce manifests and contract coverage without altering existing routes or browser runtime behavior. No merge-blocking current-head risk remains. Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (9 skipped: 9 unsupported.)
Warning Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1022e8f to
d5630df
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Problem
The repository already vendors several e-commerce Browser Act skills, but most of the executable packs are not exposed through the existing
channel.manifest.jsoncontract. They therefore cannot be selected and validated consistently by the generic Browser Act channel.Changes
Compatibility
/browser-act/*routes remain unchanged.Testing
On commit
1022e8f2:uv run pytest tests/unit/browser_act_packs/test_ecommerce_manifests.py tests/unit/browser_act_packs/test_manifest.py tests/integration/test_browser_act_packs_api.py tests/integration/test_browser_act_seeds.py tests/unit/channels/test_browser_act_channel.py --no-cov -q— 56 passeduv run ruff check tests/unit/browser_act_packs/test_ecommerce_manifests.py tests/integration/test_browser_act_packs_api.py— passedgit diff --check— passedNo live third-party e-commerce browser run is claimed here. Platform login, regional access, anti-bot responses, and selector drift remain operational limitations of the existing packs.
Non-goals