Skip to content

feat(browser-act): enable ecommerce packs - #113

Merged
2233admin merged 1 commit into
2233admin:mainfrom
chuanxu742-glitch:contrib/ecommerce-packs
Sep 6, 2026
Merged

feat(browser-act): enable ecommerce packs#113
2233admin merged 1 commit into
2233admin:mainfrom
chuanxu742-glitch:contrib/ecommerce-packs

Conversation

@chuanxu742-glitch

Copy link
Copy Markdown
Collaborator

Problem

The repository already vendors several e-commerce Browser Act skills, but most of the executable packs are not exposed through the existing channel.manifest.json contract. They therefore cannot be selected and validated consistently by the generic Browser Act channel.

Changes

  • Add executable manifests for nine existing e-commerce packs:
    • generic listing, product detail, reviews, and seller information
    • Goofish item detail and search list
    • Taobao product detail, reviews, and shop catalog
  • Declare each pack's input parameters, browser steps, pagination mode, and success field.
  • Add manifest contract coverage for the pack-to-script mappings.
  • Update the catalog API regression fixture so the newly seeded manifests are tracked explicitly.

Compatibility

  • Reuses the existing Browser Act manifest and CLI execution path.
  • No new dependency, database migration, public API route, or browser runtime is introduced.
  • Existing packs and /browser-act/* routes remain unchanged.

Testing

On commit 1022e8f2:

  • uv run pytest tests/unit/browser_act_packs/test_ecommerce_manifests.py tests/unit/browser_act_packs/test_manifest.py tests/integration/test_browser_act_packs_api.py tests/integration/test_browser_act_seeds.py tests/unit/channels/test_browser_act_channel.py --no-cov -q — 56 passed
  • uv run ruff check tests/unit/browser_act_packs/test_ecommerce_manifests.py tests/integration/test_browser_act_packs_api.py — passed
  • git diff --check — passed

No live third-party e-commerce browser run is claimed here. Platform login, regional access, anti-bot responses, and selector drift remain operational limitations of the existing packs.

Non-goals

  • Adding a second CDP/browser transport.
  • Automating login, captcha solving, or anti-bot bypass.
  • Adding market data, page monitoring, or Kuaishou support.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: ad2a1338-bdd7-473b-af3c-87e9f31fece1

📥 Commits

Reviewing files that changed from the base of the PR and between 5e04641 and d5630df.

📒 Files selected for processing (11)
  • backend/browser_act_packs/ecommerce/ecommerce-listing/channel.manifest.json
  • backend/browser_act_packs/ecommerce/ecommerce-product-detail/channel.manifest.json
  • backend/browser_act_packs/ecommerce/ecommerce-reviews/channel.manifest.json
  • backend/browser_act_packs/ecommerce/ecommerce-seller-info/channel.manifest.json
  • backend/browser_act_packs/ecommerce/goofish-item-detail/channel.manifest.json
  • backend/browser_act_packs/ecommerce/goofish-search-list/channel.manifest.json
  • backend/browser_act_packs/ecommerce/taobao-product-detail/channel.manifest.json
  • backend/browser_act_packs/ecommerce/taobao-product-reviews/channel.manifest.json
  • backend/browser_act_packs/ecommerce/taobao-shop-catalog/channel.manifest.json
  • tests/integration/test_browser_act_packs_api.py
  • tests/unit/browser_act_packs/test_ecommerce_manifests.py
🚧 Files skipped from review as they are similar to previous changes (11)
  • backend/browser_act_packs/ecommerce/taobao-product-reviews/channel.manifest.json
  • backend/browser_act_packs/ecommerce/goofish-item-detail/channel.manifest.json
  • backend/browser_act_packs/ecommerce/taobao-product-detail/channel.manifest.json
  • backend/browser_act_packs/ecommerce/ecommerce-seller-info/channel.manifest.json
  • backend/browser_act_packs/ecommerce/ecommerce-listing/channel.manifest.json
  • backend/browser_act_packs/ecommerce/goofish-search-list/channel.manifest.json
  • backend/browser_act_packs/ecommerce/ecommerce-reviews/channel.manifest.json
  • tests/unit/browser_act_packs/test_ecommerce_manifests.py
  • backend/browser_act_packs/ecommerce/ecommerce-product-detail/channel.manifest.json
  • backend/browser_act_packs/ecommerce/taobao-shop-catalog/channel.manifest.json
  • tests/integration/test_browser_act_packs_api.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Summary

Summary by CodeRabbit

  • New Features

    • Added e-commerce browsing for product listings, product details, reviews, seller information, and shop catalogs.
    • Added Goofish search and item-detail capabilities.
    • Added Taobao product details, reviews, and shop catalog capabilities.
    • Added configurable result limits and paginated shop catalog browsing.
  • Tests

    • Added validation coverage for e-commerce capability configurations, extraction requirements, and supported browsing steps.

Walkthrough

Added nine ecommerce browser action manifests for general ecommerce, Goofish, and Taobao extraction flows. Added integration registration and unit tests that validate manifest fields, extraction scripts, and supported step operations.

Changes

Ecommerce browser action packs

Layer / File(s) Summary
General ecommerce manifests
backend/browser_act_packs/ecommerce/ecommerce-listing/channel.manifest.json, backend/browser_act_packs/ecommerce/ecommerce-product-detail/channel.manifest.json, backend/browser_act_packs/ecommerce/ecommerce-reviews/channel.manifest.json, backend/browser_act_packs/ecommerce/ecommerce-seller-info/channel.manifest.json
Added navigation, stable-wait, extraction, pagination, parameter, and success definitions for general ecommerce capabilities.
Goofish and Taobao manifests
backend/browser_act_packs/ecommerce/goofish-*/channel.manifest.json, backend/browser_act_packs/ecommerce/taobao-*/channel.manifest.json
Added item, search, product, review, and shop catalog manifests with platform-specific parameters, extraction scripts, pagination behavior, and success fields.
Manifest registration and validation
tests/integration/test_browser_act_packs_api.py, tests/unit/browser_act_packs/test_ecommerce_manifests.py
Registered the new pack paths and added checks for manifest identity, extraction scripts, required fields, and supported step operations.

Estimated code review effort: 2 (Simple) | ~15 minutes

Merge Risk: ⚪ Minimal · up to d5630

This change adds executable e-commerce manifests and contract coverage without altering existing routes or browser runtime behavior. No merge-blocking current-head risk remains.

Poem

A rabbit checks each pack,
Nine manifests line the trail,
Scripts wait behind the paths,
Tests guard each required field,
Clean steps lead the review home.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (9 skipped: 9 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: enabling ecommerce Browser Act packs.
Description check ✅ Passed The description directly explains the manifest additions, test coverage, compatibility, and non-goals.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (9 skipped: 9 unsupported.)

  • Fix all pre-merge checks with AI

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@2233admin
2233admin force-pushed the contrib/ecommerce-packs branch from 1022e8f to d5630df Compare September 6, 2026 02:16
@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@2233admin
2233admin merged commit 69c0ad1 into 2233admin:main Sep 6, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants