Skip to content

fix(ui): normalize Tk padding values - #6

Merged
2002yy merged 1 commit into
mainfrom
fix/tk-padding-type-20260924
Sep 24, 2026
Merged

2002yy merged 1 commit into
mainfrom
fix/tk-padding-type-20260924

Conversation

@2002yy

@2002yy 2002yy commented Sep 24, 2026

Copy link
Copy Markdown
Owner

What changed

  • normalize the bottom ttk padding value to a Python int before adding it to the computed content height

Why

The current Windows 2025/Tk runner returns ttk padding elements as _tkinter.Tcl_Obj. _calc_content_height() added that object directly to an int, causing 17 GUI smoke tests to fail at application construction with TypeError.

The frame padding is constructed from integer constants, so int(str(pad[3])) preserves the existing layout value while making the calculation independent of Tk's Python wrapper type.

This keeps the GUI tests fail-closed; no runner pinning, skipping, or continue-on-error workaround is added.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@2002yy
2002yy merged commit 5e65d88 into main Sep 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant