Skip to content

fix(desktop): align electron-builder identity tests with DeepCode app ids | 桌面身份测试对齐 - #15

Merged
yuanchenglu merged 1 commit into
developfrom
fix/desktop-identity-tests
Oct 8, 2026
Merged

yuanchenglu merged 1 commit into
developfrom
fix/desktop-identity-tests

Conversation

@yuanchenglu

Copy link
Copy Markdown
Owner

What | 变更

  • packages/desktop/electron-builder.config.test.ts: channel expectations ai.opencode.desktop.* → ai.deepcode.desktop.*(3 行)
  • 与 S3-07(da81517)桌面身份迁移对齐;legacy .desktop 兼容测试按设计不变。

Test evidence | 测试证据

  • bun test electron-builder.config.test.ts → 4 pass / 0 fail(修复前 1 pass / 3 fail)

… ids | 桌面身份测试对齐 DeepCode app id

English: S3-07 (da81517) migrated the desktop identity to ai.deepcode.desktop.*, but electron-builder.config.test.ts still asserted the legacy ai.opencode.desktop.* ids, failing 3 of 4 tests. Update the channel table to the DeepCode ids; the legacy .desktop compatibility test stays unchanged by design.

简体中文:S3-07(da81517)已将桌面身份迁移到 ai.deepcode.desktop.*,但 electron-builder.config.test.ts 仍断言旧值,导致 4 个测试中 3 个失败。将渠道表更新为 DeepCode 身份;legacy .desktop 兼容测试按设计保持不变。
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T09:30:45.198009Z 0321c11 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@yuanchenglu
yuanchenglu merged commit df06e6b into develop Oct 8, 2026
9 checks passed
@yuanchenglu
yuanchenglu deleted the fix/desktop-identity-tests branch October 8, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant