From 0c2a5398ea902e46b986b08281b065de08ea046e Mon Sep 17 00:00:00 2001 From: Abel Vertesy Date: Sun, 30 Aug 2026 18:33:57 +0200 Subject: [PATCH 1/2] Fix discarded return value and missing variable in 2 functions ReplaceSpecialCharacters() called ReplaceRepeatedDots(x) but discarded its result, so repeated dots were never actually collapsed. parFlags() referenced an undefined `namez`, erroring on every call. Co-Authored-By: Claude Sonnet 5 --- R/Stringendo.R | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/R/Stringendo.R b/R/Stringendo.R index fd4652f..b78a6a6 100644 --- a/R/Stringendo.R +++ b/R/Stringendo.R @@ -552,7 +552,7 @@ ReplaceSpecialCharacters <- function(string = "obj@meta$alpha[[3]]", replacement # Replace " ." or ". " with "." x <- gsub(x = x, pattern = " \\.", replacement = ".", perl = TRUE) x <- gsub(x = x, pattern = "\\. ", replacement = ".", perl = TRUE) - ReplaceRepeatedDots(x) + x <- ReplaceRepeatedDots(x) if (remove_dots) x <- gsub(x = x, pattern = "\\.", replacement = "") else x } @@ -1577,6 +1577,7 @@ parFlags <- function(prefix = "", collapsechar = ".") { .Deprecated("parFlags2") val <- c(...) + namez <- as.character(as.list(match.call())[-(1:2)]) names(val) <- namez flg <- names(val)[val] print(flg) From b9f616c852ad617d13cd02fe33f031f8e9b8d407 Mon Sep 17 00:00:00 2001 From: "claude[bot]" <41898282+claude[bot]@users.noreply.github.com> Date: Mon, 31 Aug 2026 16:46:55 +0000 Subject: [PATCH 2/2] Fix parFlags() namez extraction to only read dots arguments match.call() included every supplied argument (prefix, pasteflg, collapsechar), so slicing off the first two elements broke as soon as a control argument was passed or reordered. Extract names directly from the `...` pairlist instead, using each argument's explicit name when given or its deparsed expression otherwise. Co-authored-by: Abel Vertesy <5101911+vertesy@users.noreply.github.com> --- R/Stringendo.R | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/R/Stringendo.R b/R/Stringendo.R index b78a6a6..9267417 100644 --- a/R/Stringendo.R +++ b/R/Stringendo.R @@ -1577,7 +1577,11 @@ parFlags <- function(prefix = "", collapsechar = ".") { .Deprecated("parFlags2") val <- c(...) - namez <- as.character(as.list(match.call())[-(1:2)]) + dotz <- match.call(expand.dots = FALSE)$"..." + namez <- vapply(seq_along(dotz), function(i) { + nm <- names(dotz)[i] + if (!is.null(nm) && nzchar(nm)) nm else deparse(dotz[[i]]) + }, character(1)) names(val) <- namez flg <- names(val)[val] print(flg)