Repository navigation
Fix failing tests and remove Claude workflows - #352
Merged
Merged
Conversation
test_filename_poster_and_embed_snippet assumed Chromium can't read H.264 metadata, so the embed snippet would have no width/height. Newer Playwright Chromium builds can, so the test failed on every CI run since 2026-09-07. It now expects the size whenever the page detected it. test_github_repo_analysis called the live GitHub API unauthenticated, which fails intermittently once shared CI runners hit the rate limit. It now analyzes a mocked two-file repository. The Claude Code Review workflow has failed on every PR since July because its OAuth token expired. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0139NfxSqowttMWdKwMQ7hYM
test_webp_format_switches_settings, added in #351, has the same assumption as the <video> snippet test: newer Playwright Chromium reads the source size up front, so the <img> snippet carries width/height. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0139NfxSqowttMWdKwMQ7hYM
It used the same expired CLAUDE_CODE_OAUTH_TOKEN secret as the Claude Code Review workflow, so @claude mentions would fail too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0139NfxSqowttMWdKwMQ7hYM
Deploying tools with
|
| Latest commit: |
f8ef97c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://00da793b.tools-b1q.pages.dev |
| Branch Preview URL: | https://fix-ci-tests.tools-b1q.pages.dev |
simonw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude Opus 5.5
The Test workflow has been red on
mainsince 2026-09-07, and Claude Code Review has failed on every PR since July. This gets Test green again (run #1898).Video compressor embed snippet tests.
test_filename_poster_and_embed_snippet(the<video>snippet) andtest_webp_format_switches_settings(the<img>snippet, added in #351) assumed Playwright's Chromium can't read the H.264 test video's metadata. If it can't, the snippet has nowidth/height. CI installs the latest Playwright, whose Chromium can read it, so the snippets gainedwidth="640" height="360"and the assertions failed. Both tests now expect the size whenever the page detected it (640×360in#source-details). I checked both cases: without the size, using an older Chromium, and with it.Sloccount GitHub test.
test_github_repo_analysiscalled the realapi.github.comwithout authentication. That fails intermittently once shared CI runners hit the 60 requests/hour limit. It now analyses a fake two-file repository served withpage.route, and checks that the result is 2 files in 2 languages.Claude workflows removed.
claude-code-review.ymlfailed on every run since 2026-07-10 withOAuth access token has expired.claude.yml(@claudementions) used the sameCLAUDE_CODE_OAUTH_TOKENsecret and is removed too. Nothing else references that secret, so it can be deleted from the repo settings.🤖 Generated with Claude Code
https://claude.ai/code/session_0139NfxSqowttMWdKwMQ7hYM