From b9518f959eb396f321401fb59c337a1e5ef4164a Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Thu, 29 Oct 2026 14:35:06 +0000 Subject: [PATCH 1/2] chore(deps): update dependency com.google.errorprone:error_prone_core to v2.51.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 69f2f5614..35832e4fa 100644 --- a/pom.xml +++ b/pom.xml @@ -477,7 +477,7 @@ com.google.errorprone error_prone_core - 2.50.0 + 2.51.0 com.uber.nullaway From c8bd5853d0a5beb2f3c387012858f389fc2a11ca Mon Sep 17 00:00:00 2001 From: Gregor Zeitlinger Date: Fri, 30 Oct 2026 12:58:43 +0000 Subject: [PATCH 2/2] fix: preserve Unit hash semantics without Error Prone warning Signed-off-by: Gregor Zeitlinger --- .../java/io/prometheus/metrics/model/snapshots/Unit.java | 2 +- .../io/prometheus/metrics/model/snapshots/UnitTest.java | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/Unit.java b/prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/Unit.java index 818f14416..9472eeeba 100644 --- a/prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/Unit.java +++ b/prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/Unit.java @@ -75,6 +75,6 @@ public boolean equals(Object o) { @Override public int hashCode() { - return Objects.hash(name); + return 31 + Objects.hashCode(name); } } diff --git a/prometheus-metrics-model/src/test/java/io/prometheus/metrics/model/snapshots/UnitTest.java b/prometheus-metrics-model/src/test/java/io/prometheus/metrics/model/snapshots/UnitTest.java index e288a2375..17cfa12e0 100644 --- a/prometheus-metrics-model/src/test/java/io/prometheus/metrics/model/snapshots/UnitTest.java +++ b/prometheus-metrics-model/src/test/java/io/prometheus/metrics/model/snapshots/UnitTest.java @@ -43,4 +43,13 @@ void testEquals4() { assertThat(unit1).isEqualTo(unit2); } + + @Test + void testEqualUnitsHaveEqualHashCodes() { + Unit unit1 = new Unit(" bytes "); + Unit unit2 = new Unit("bytes"); + + assertThat(unit1).isEqualTo(unit2); + assertThat(unit1.hashCode()).isEqualTo(unit2.hashCode()); + } }