Repository navigation
Conversation
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryUpdates
Reviews (1) · Last reviewed commit: "fix(readnovelfull): separate novel genre..." · Reviewed by Greptile |
|
is this not ready for merge yet? i saw other PRs getting merged that were made after this one |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the mixed-up genre display reported in #2720 (e.g. Novel Ping showing "Fan-fictionActionRomance..." for a novel's genres).
Root cause: in parseNovel, the info block's text nodes were joined into a single string before splitting into lines, so genre chips rendered as separate elements lost their boundaries and came out concatenated. The genre line is now split into its individual items first, then joined with ", ". The same fix is applied to the genre-array fallback path, which joined with an empty string.
Tested:
Closes #2720