Skip to content

fix(readnovelfull): separate novel genres with commas - #2729

Open
RevDev909 wants to merge 1 commit into
lnreader:masterfrom
RevDev909:fix-readnovelfull-genres
Open

RevDev909 wants to merge 1 commit into
lnreader:masterfrom
RevDev909:fix-readnovelfull-genres

Conversation

@RevDev909

Copy link
Copy Markdown
Contributor

Fixes the mixed-up genre display reported in #2720 (e.g. Novel Ping showing "Fan-fictionActionRomance..." for a novel's genres).

Root cause: in parseNovel, the info block's text nodes were joined into a single string before splitting into lines, so genre chips rendered as separate elements lost their boundaries and came out concatenated. The genre line is now split into its individual items first, then joined with ", ". The same fix is applied to the genre-array fallback path, which joined with an empty string.

Tested:

  • Reproduced on a live Novel Ping novel page before the fix ("Fan-fictionActionRomanceAdventureSystemComedyHarem"), confirmed separated output after ("Fan-fiction, Action, Romance, Adventure, System, Comedy, Harem"), with author and status unchanged.
  • Regenerated the multisrc output and ran the plugin live check on Novel Ping: popularNovels, searchNovels, parseNovel (3221 chapters) and parseChapter all pass.
  • eslint clean (one pre-existing unused-var warning), prettier clean.

Closes #2720

@greptile-apps

greptile-apps Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Updates parseNovel to preserve genre boundaries and join genres with commas.

  • Novel details keep each genre separate with commas.

Reviews (1) · Last reviewed commit: "fix(readnovelfull): separate novel genre..." · Reviewed by Greptile

@MonomoySama

Copy link
Copy Markdown

is this not ready for merge yet? i saw other PRs getting merged that were made after this one

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Novel Ping Genre mixed

2 participants