Repository navigation
fix(release): stage README.md so the CDN pin bump is committed - #162
Merged
Merged
Conversation
release.sh rewrites the README's CDN pins (bump_version) and restores README.md on failure, but commit_and_tag's `git add` list left it out. Every release therefore left README.md modified on main, and the next release's clean-tree check refused to start until someone committed it. Also commits the pins the v0.25.2 release left behind (0.20.0 -> 0.25.2). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H17jLWktjd8RmZim6vf8RJ
|
Review: LGTM.
I found no bugs or security issues. One optional follow-up: add a CI or lint check that the README pin equals I read the diff and grepped the script. I did not run the release flow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/release.shupdates the README's CDN pins inbump_versionand includesREADME.mdin its failure-restore list, butcommit_and_tagonly stagesVERSION package.json package-lock.json CHANGELOG.md. As a result, every release leavesREADME.mdmodified onmain, and the next release's clean-tree check refuses to run until someone commits it by hand. That happened with both v0.25.1 and v0.25.2.scripts/release.sh: addREADME.mdto thegit addincommit_and_tag.README.md: commit the pins left behind by the v0.25.2 release (0.20.0 → 0.25.2).Tests:
npm test: 897 passed, 1 skipped.bash -n scripts/release.shsucceeds. The real proof is the next release leaving a clean tree.🤖 Generated with Claude Code
https://claude.ai/code/session_01H17jLWktjd8RmZim6vf8RJ