Skip to content

Housekeeping: eager model load, lint noise, .gitignore #16

Description

@peterbjohnson

Low-risk cleanup, grouped because none of it is urgent on its own.

Load the Basic Pitch model lazily. evaluation.py calls load_basic_pitch_model() at import time, so every cold start and every test run pays for it even when the submission is pure MIDI and no transcription is needed. Load on first audio input instead.

Lint noise. The advisory flake8 pass reports 267 warnings. The bulk is mechanical:

  • trailing whitespace on 120 lines
  • 8 unused imports in evaluation_test.py
  • ~37 redundant backslash continuations inside brackets

One formatter pass would clear nearly all of it, and would make the CI advisory output meaningful again.

.gitignore. No .DS_Store entry; two are currently untracked in the working tree.

Notebook size. The three summary notebooks commit about 3.7 MB of outputs (Phase2_summary.ipynb alone is 2.4 MB). Reasonable for a report, but worth a note in notebooks/README.md about whether outputs should be kept on future edits.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions