Minor mistake in Code of 7.1-exception.ipynb

[kumarmohit0911]

While i was going through ur codes i found a minor mistake in the above mentioned file i.e,Complete-Python-Bootcamp/7-Exception Handling
/7.1-exception.ipynb
In the very third cell from bottom u typed file.closed() but file.close
here there won't be any parenthesis as closed is not a method but a property which returns boolean value. And its not throwing error bcoz it is not getting executed as u have used or operator.
Ik it is very small thing and u just missed on it but i would love to make changes as it is my first time i found an error in others code.
and also thanks for being such a good teacher.

[mjbear]

Agree with @kumarmohit0911

Complete-Python-Bootcamp/7-Exception Handling/7.1-exception.ipynb

Line 245 in cb4a197

" if 'file' in locals() or not file.closed():\n",

Complete-Python-Bootcamp/7-Exception Handling/7.1-exception.ipynb

Line 286 in cb4a197

"not file.closed()"

If @krishnaik06 will accept a pull request you could submit one. 😉

[kumarmohit0911]

Agree with @kumarmohit0911

Complete-Python-Bootcamp/7-Exception Handling/7.1-exception.ipynb

Line 245 in cb4a197

" if 'file' in locals() or not file.closed():\n",

Complete-Python-Bootcamp/7-Exception Handling/7.1-exception.ipynb

Line 286 in cb4a197

"not file.closed()"

If @krishnaik06 will accept a pull request you could submit one. 😉

was it sarcasm or u really agree with me!!?? and can u pls tell what u mean by this "If @krishnaik06 will accept a pull request you could submit one. 😉" . I am new to all these so i can't understant... not the technical words but ur winking.

[mjbear]

Hello @kumarmohit0911
I was not being sarcastic. You are correct that file.closed is a property not a method.

It would only make sense for you to put together a pull request if Krish was willing to merge in people's edits.
Oh, the wink emoji - I can see how that might be misinterpreted. I was being playful and implying that pull requests are a good way to improve the content and give back. 😁

Hopefully that clarifies.

[kumarmohit0911]

Actually Idk much about that and I thought I had given a PR.... Is that not PR?! If not can u please tell me where to give PR?

…

On Sat, 16 Nov 2024, 19:03 Michael Bear, ***@***.***> wrote: Hello @kumarmohit0911 <https://github.com/kumarmohit0911> I was not being sarcastic. You are correct that file.closed is a property not a method. It would only make sense for you to put together a pull request if Krish was willing to merge in people's edits. Oh, the wink emoji - I can see how that might be misinterpreted. I was being playful and implying that pull requests are a good way to improve the content and give back. 😁 Hopefully that clarifies. — Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BJAOXSJWLNC6U5MYVFA26F32A5CS5AVCNFSM6AAAAABPBTXCACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBQGU3DENBVGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[mjbear]

Actually Idk much about that and I thought I had given a PR.... Is that not PR?! If not can u please tell me where to give PR?
…
On Sat, 16 Nov 2024, 19:03 Michael Bear, @.> wrote: Hello @kumarmohit0911 https://github.com/kumarmohit0911 I was not being sarcastic. You are correct that file.closed is a property not a method. It would only make sense for you to put together a pull request if Krish was willing to merge in people's edits. Oh, the wink emoji - I can see how that might be misinterpreted. I was being playful and implying that pull requests are a good way to improve the content and give back. 😁 Hopefully that clarifies. — Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BJAOXSJWLNC6U5MYVFA26F32A5CS5AVCNFSM6AAAAABPBTXCACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBQGU3DENBVGU . You are receiving this because you were mentioned.Message ID: @.>

@kumarmohit0911
No, an issue is not a pull request (PR)
This is an issue thread.

https://github.blog/developer-skills/github/beginners-guide-to-github-creating-a-pull-request/

Edit: Add more clarity.

[kumarmohit0911]

in that particular code there is no option to clone the repo and without cloning how we can send pr?

[mjbear]

@kumarmohit0911
You'll learn something from going through this process.
Though be aware that Krish @krishnaik06 doesn't seem to be responsive so it's uncertain when/if this could get merged in.

in that particular code there is no option to clone the repo and without cloning how we can send pr?

1. First you fork.
2. Create a feature branch (recommended).
3. Make and commit changes to your feature branch.
4. Submit a PR.
   • In that PR, you can link it to this issue by putting resolves #4 (where #4 is this issue number) in the initial description along with your description.

[kumarmohit0911]

Thank you, I will do that.

…

On Mon, 18 Nov 2024, 00:16 Michael Bear, ***@***.***> wrote: @kumarmohit0911 <https://github.com/kumarmohit0911> You'll learn something from going through this process. Though be aware that Krish @krishnaik06 <https://github.com/krishnaik06> doesn't seem to be responsive so it's uncertain when/if this could get merged in. in that particular code there is no option to clone the repo and without cloning how we can send pr? 1. First you fork <https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repo> . 2. Create a feature branch <https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-and-deleting-branches-within-your-repository> (recommended). 3. Make and commit changes to your feature branch. 4. Submit a PR <https://github.blog/developer-skills/github/beginners-guide-to-github-creating-a-pull-request/>. - In that PR, you can link it to this issue <https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests> by putting resolves #4 (where #4 is this issue number) in the initial description along with your description. — Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BJAOXSMTMIEALD7IEHEFDW32BDQAZAVCNFSM6AAAAABPBTXCACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBRGQZDIMJSGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[kumarmohit0911]

@kumarmohit0911 You'll learn something from going through this process. Though be aware that Krish @krishnaik06 doesn't seem to be responsive so it's uncertain when/if this could get merged in.

in that particular code there is no option to clone the repo and without cloning how we can send pr?

1. First you fork.

2. Create a feature branch (recommended).

3. Make and commit changes to your feature branch.

4. Submit a PR.

   • In that PR, you can link it to this issue by putting resolves #4 (where #4 is this issue number) in the initial description along with your description.

i think i have submitted the PR .. it will be very kind of u if u can check PR has been added or not

[mjbear]

@kumarmohit0911
Normally the issue ticket stays open until the PR has been merged in.
Krish would close both the issue and the PR once the PR is merged.

Yes, you have PR #7 waiting for review.

[kumarmohit0911]

@kumarmohit0911 Normally the issue ticket stays open until the PR has been merged in. Krish would close both the issue and the PR once the PR is merged.

Yes, you have PR #7 waiting for review.

thank u for guiding me through!!
i will see some youtube videos about using github