Skip to content

Harden benchmark workflow execution - #171

Open
rgarcia wants to merge 1 commit into
mainfrom
hypeship/fix-benchmark-pr-comments
Open

Harden benchmark workflow execution#171
rgarcia wants to merge 1 commit into
mainfrom
hypeship/fix-benchmark-pr-comments

Conversation

@rgarcia

@rgarcia rgarcia commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep PR comment failures from stopping benchmark execution or publication
  • use the project scope embedded in the dedicated benchmark credential instead of a separately configured project value
  • flag and suppress deltas for all-ungraded runs, and refuse to publish them as valid experiments

Validation

  • bun test (262 tests)
  • bunx tsc --noEmit --incremental false
  • bun run build with required placeholder configuration
  • Actionlint
  • Zizmor
  • git diff --check
  • real single-task Harbor run reached interception and produced verifier rewards with the project pin removed

@vercel

vercel Bot commented Aug 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
mcp Ready Ready Preview Aug 30, 2026 7:40pm

@rgarcia
rgarcia force-pushed the hypeship/fix-benchmark-pr-comments branch from 75e1ed6 to 1511e44 Compare August 30, 2026 19:40
@rgarcia rgarcia changed the title Keep benchmark runs independent of PR comments Harden benchmark workflow execution Aug 30, 2026
@rgarcia

rgarcia commented Aug 30, 2026

Copy link
Copy Markdown
Contributor Author

@bmsaadat the first default-branch dispatch exposed two runtime issues: PR-commenting could stop the job, and the separately configured project name conflicted with the project ID embedded in the benchmark key. This patch removes that duplicate pin, fails closed on all-ungraded arms, and prevents publishing them. I reproduced the original setup failure locally, then reran the same task without the pin: MCP initialized, interception succeeded, verifier rewards were written, and cleanup completed. All checks and BugBot are green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant