specs of gen_server2

[kostis]

I was trying to track the origin of gen_server2 and I came to this place. Apologies if it's not the real origin.

I noticed that old fashioned specs are still used in the code:

-spec(hibernate/1 :: (gs2_state()) -> no_return()).

You may want to modernize these and make them look as follows:

-spec hibernate(gs2_state()) -> no_return().

Also, perhaps the use_specs ifdef is not needed anymore.

[hyperthunk]

Hi Kostis - thanks for pointing this out. The gen_server2 code is synced from the rabbitmq mercurial repository. I've been discussing with them to maintain the gen_server2 code as a separate repo or to get it fully contributed to OTP. In the meanwhile, I'll patch the -specs and submit back to their repo and see if they're willing to accept the change for now.

Cheers!