From 85fa5429e5a16a06d581aacfc59a274a72a4708d Mon Sep 17 00:00:00 2001 From: Vadim Zolotokrylin <1125014+zolotokrylin@users.noreply.github.com> Date: Thu, 17 Sep 2026 19:04:35 +0800 Subject: [PATCH] docs(rules): mark PRs ready and keep disagreements open --- docs/rules/DEV-365.md | 5 +++-- docs/rules/DEV-460.md | 8 +++++--- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/docs/rules/DEV-365.md b/docs/rules/DEV-365.md index 0003946..8f3ab61 100644 --- a/docs/rules/DEV-365.md +++ b/docs/rules/DEV-365.md @@ -22,8 +22,9 @@ opens half-finished work. 1. Include a preview link when the change is visually verifiable. 1. Mark ready for review only once the PR is a linked, self-assigned draft (per [DEV-360](./DEV-360.md)) with a reviewer and a preview where applicable. -1. Resolve all CI checks. CI runs after the PR is marked ready, so do not - request approval until it passes. +1. Resolve all CI checks. Some checks run on drafts and some only once the PR is + marked ready, so fix draft-stage failures before marking it ready, and do not + request approval until every check passes. 1. Do not merge without an approved review and passing CI. ### Acceptance Criteria diff --git a/docs/rules/DEV-460.md b/docs/rules/DEV-460.md index 122acde..917ab89 100644 --- a/docs/rules/DEV-460.md +++ b/docs/rules/DEV-460.md @@ -20,11 +20,13 @@ the thread settled; the reply carries the answer. 1. Reply to every inline thread before you merge, and name what changed. One sentence is enough. -1. Resolve the thread after you post that reply and push the fix. +1. Resolve the thread after you post that reply and the answer is applied or + accepted: the fix is pushed, or the reviewer accepts an answer that needs no + change. 1. When you fixed it in another PR, the Problem, or a follow-up issue, say which one and give its number. -1. Reply and leave the thread open when you disagree. The reviewer decides, per - [DEV-410](./DEV-410.md). +1. When you disagree, reply with why and leave the thread open. The reviewer + decides, per [DEV-410](./DEV-410.md). ```md Good: fixed in 4a1c2f0, the heading is now `###`. [Resolve]