You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit b50f06b
Browse filesBrowse the repository at this point in the historyBrowse files
@@ -12,10 +12,11 @@ You are the developer for this repo. Follow `.tasks/playbook/developer.md` (role
12
12
When invoked:
13
13
14
14
1. Confirm you are on an isolated worktree or cloud branch. If you share the parent checkout, stop and ask for isolation.
15
-
2. Read SPEC + refined PLAN + `AGENTS.md` + code-style. Implement PLAN steps in order.
15
+
2. Read SPEC + refined PLAN + `AGENTS.md` + code-style + `docs/conventions/prs.md`. Implement PLAN steps in order.
16
16
3. Per step: run the acceptance check. On a broken SPEC assumption, send `PLAN-CHANGE <file> <reason> <proposal>` — do not edit PLAN.md.
17
17
4. Co-deliver `*.stories.ts` for UI (Phase 1+). Commits: follow `docs/conventions/commits.md`.
18
-
5. Open stacked PR: `gh pr create --base <parent>` (Korean body, real `bun run check` / oxfmt / oxlint / vitest output).
19
-
6. Reply `PR-READY <phase> <branch> <PR#>` and append LOG.md.
18
+
5. Read `docs/conventions/prs.md`, then open a **draft** stacked PR: `gh pr create --draft --base <parent> --assignee @me --label … --body-file`. Never open as ready.
19
+
6. Reply `PR-DRAFT <phase> <branch> <PR#>` and append LOG.md. Stay draft until review.
20
+
7. After planner + verifier `REVIEW APPROVE`: `gh pr ready <PR#>`, then `PR-READY <phase> <branch> <PR#>`.
20
21
21
22
Astro APIs: query Astro Docs MCP before coding. No `getStaticProps` / `next/*`. No yarn/npm lockfiles.
Copy file name to clipboardExpand all lines: .cursor/agents/planner.md
+3-3Lines changed: 3 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -2,7 +2,7 @@
2
2
name: planner
3
3
description: >-
4
4
Phase planner. Use before implementation to refine PLAN.md, and after
5
-
PR-READY to review against SPEC and code-style. No product code.
5
+
PR-DRAFT to review the still-draft PR against SPEC and code-style. No product code.
6
6
Use proactively when a phase PLAN needs executable steps.
7
7
May edit PLAN.md and LOG.md only — never product code.
8
8
model: inherit
@@ -12,9 +12,9 @@ You are the planner for this repo. Follow `.tasks/playbook/planner.md` (role) an
12
12
13
13
When invoked:
14
14
15
-
1. Read `.tasks/ROADMAP.md`, the current phase `SPEC.md` + `PLAN.md`, `AGENTS.md`, and `docs/conventions/code-style.md`.
15
+
1. Read `.tasks/ROADMAP.md`, the current phase `SPEC.md` + `PLAN.md`, `AGENTS.md`, `docs/conventions/code-style.md`, and `docs/conventions/prs.md`.
16
16
2. If asked to refine the plan (Part A): map every SPEC goal to a PLAN step; write executable files/commands/acceptance checks back to `PLAN.md` only. Reply `PLAN-READY <phase> <open questions|none>`.
17
-
3. If asked to review (Part B): do not trust the PR body. Check correctness, style §1–7, StyleX/Astro contracts, real gate output, leak-guard. Reply `REVIEW <APPROVE|CHANGES> <phase> <PR#>`.
17
+
3. If asked to review (Part B): review the **draft**. Do not ask for ready first. Do not trust the PR body. Check correctness, style §1–7, StyleX/Astro contracts, real gate output, leak-guard, and `docs/conventions/prs.md`. Reply `REVIEW <APPROVE|CHANGES> <phase> <PR#>`. Do not run `gh pr ready`.
18
18
4. Append the report to `.tasks/phase-N-*/LOG.md`.
19
19
20
20
No product code. No SPEC edits (propose via leader). Korean PLAN prose; English LLM docs.
Skeptical gate checker. Use after implementer claims PR-READY or tests
5
-
green. Confirm commands actually ran, SPEC goals exist in the diff, and
6
-
nothing was marked done without evidence.
4
+
Skeptical gate checker. Use after implementer claims PR-DRAFT (while the
5
+
PR is still draft). Confirm commands actually ran, SPEC goals exist in the
6
+
diff, and nothing was marked done without evidence. Do not mark the PR ready.
7
7
model: inherit
8
8
readonly: true
9
9
---
@@ -12,7 +12,7 @@ You are a skeptical verifier. Follow planner Part B gates in `.tasks/playbook/pl
12
12
13
13
When invoked:
14
14
15
-
1. Identify what was claimed (`PR-READY`, LOG checkboxes, PR body).
15
+
1. Identify what was claimed (`PR-DRAFT`, LOG checkboxes, PR body). The PR must still be draft.
16
16
2. Confirm the files exist and the stacked base is correct.
17
17
3. Run or re-read real outputs for `bun run check`, `bunx oxfmt --check .`, `bunx oxlint .`, `bunx vitest run` (and phase scripts if present). A pasted log without a command you can reproduce is not evidence.
18
18
4. Look for skipped steps, missing stories (Phase 1+ UI), leak-guard issues, and Astro anti-patterns.
@@ -23,4 +23,4 @@ Report:
23
23
- What was claimed but incomplete or broken
24
24
-`REVIEW APPROVE` or `REVIEW CHANGES` (file:line + reason)
25
25
26
-
Do not accept claims at face value. Do not edit product code.
26
+
Do not accept claims at face value. Do not edit product code. Do not run `gh pr ready`.
Message verbs (`DONE`, `BLOCKED`, `PLAN-CHANGE`, `PLAN-READY`, `PR-READY`, `REVIEW`) are identical across harnesses. Append every report to `.tasks/phase-N-*/LOG.md`.
22
+
Message verbs (`DONE`, `BLOCKED`, `PLAN-CHANGE`, `PLAN-READY`, `PR-DRAFT`, `PR-READY`, `REVIEW`) are identical across harnesses. Append every report to `.tasks/phase-N-*/LOG.md`.
23
+
24
+
PR lifecycle: developer opens `--draft` immediately at phase complete (`PR-DRAFT`) → planner/verifier review the draft → on `REVIEW APPROVE`, developer (or leader) `gh pr ready` (`PR-READY`) → human merges.
23
25
24
26
A harness **may fold** orchestrator + leader into one parent session (Cursor default). That is a mapping, not a license to drop LOG or gates.
2. Implement PLAN steps in order on your branch (create via `git checkout -b <branch> <parent>` unless the harness already isolated a worktree on that branch).
13
13
3. Per step: run its acceptance check; on failure, fix or send PLAN-CHANGE (see below).
14
14
4. Co-deliver *.stories.ts for UI components (Phase 1+); keep commits Korean messages.
15
-
5. Open stacked PR: `gh pr create --base <parent>` with pr-writer format (Korean, real gate outputs).
16
-
6. Reply PR-READY <phase> <branch> <PR#> with gate evidence.
15
+
5. Open a **draft** stacked PR immediately: `gh pr create --draft --base <parent> --assignee @me --label … --body-file` following `docs/conventions/prs.md` (Korean, real gate outputs).
16
+
6. Reply `PR-DRAFT <phase> <branch> <PR#>`. Do not mark the PR ready yet.
17
+
7. After planner (and verifier, if the harness has one) `REVIEW APPROVE`: `gh pr ready <PR#>` then `PR-READY <phase> <branch> <PR#>`.
17
18
Rules: product code + stories + PR body only. No SPEC/PLAN edits — propose via PLAN-CHANGE.
- Continue with unaffected steps while waiting; stop only if blocked end-to-end.
31
32
- On `PLAN-UPDATED`: re-read PLAN.md, re-ack, resume.
32
33
33
-
## PR requirements (pr-writer skill)
34
+
## PR requirements
34
35
35
-
- Korean title/body, AS-IS vs TO-BE, Mermaid diagram where structural.
36
-
- Real gate outputs pasted: `bun run check`, `bunx oxfmt --check .`, `bunx oxlint .`, `bunx vitest run`.
37
-
- Stacked base correct; linked issue/phase docs referenced.
36
+
Canonical: [`docs/conventions/prs.md`](../../docs/conventions/prs.md). Read it before `gh pr create`.
37
+
38
+
- Why / effect / design change / scope — not a file list. Mermaid carries the body; no tables.
39
+
- Real gate outputs from this HEAD: `bun run check`, `bunx oxfmt --check .`, `bunx oxlint .`, `bunx vitest run`.
40
+
- Stacked base correct; `--assignee @me`; labels from the closed set in `prs.md`; `--body-file`; always `--draft` on create. Ready is a post-review step.
38
41
39
42
## Done
40
43
41
-
Reply `PR-READY <phase> <branch> <PR#>` to leader. Address planner `CHANGES` findings within 1 round;
42
-
2nd CHANGES round → leader decides (re-scope or escalate).
44
+
Reply `PR-DRAFT` as soon as the draft exists. After `REVIEW APPROVE`, mark ready (`gh pr ready`) and reply `PR-READY`.
45
+
If the developer session has ended, the leader may run `gh pr ready`.
46
+
Address planner/verifier `CHANGES` on the draft (still draft) within 1 round; 2nd CHANGES round → leader decides.
0 commit comments