[mxl862xx] FW 1.0.85 autoneg setting not compatible with PCS for lan-sfp

[mxre]

I was testing the recent firmware 1.0.85 upgrade on my R4 pro 4E. On the LAN SFP+ port I got a autoneg setting not compatible with PCS error, while a SFP+ RJ45 module was plugged in. I tested against current branch 7.1-main (73c7cc8) with patches #214 #213 #210 applied.

As a fix I tried adding code from mxl862xx_pcs_inband_caps to mxl862xx_pcs_v2_inband_caps that restored expected behavior.

--- a/drivers/net/dsa/mxl862xx/mxl862xx-phylink.c
+++ b/drivers/net/dsa/mxl862xx/mxl862xx-phylink.c
@@ -799,7 +799,8 @@ static unsigned int mxl862xx_pcs_v2_inband_caps(struct phylink_pcs *pcs,
        case PHY_INTERFACE_MODE_10GKR:
                return LINK_INBAND_ENABLE;
        case PHY_INTERFACE_MODE_10GBASER:
-               return LINK_INBAND_DISABLE;
+               return LINK_INBAND_DISABLE | LINK_INBAND_ENABLE |
+                      LINK_INBAND_BYPASS;
        default:
                return 0;
        }

I can't say if this is correct but it works for me and i wanted to ask if there were others noticing similar behavior.