From 1771d64f8a7ad83eb7c9079937c57ebde72be880 Mon Sep 17 00:00:00 2001 From: Peter Tos <38345014+bmxcode@users.noreply.github.com> Date: Sat, 5 Sep 2026 22:10:27 +1000 Subject: [PATCH 1/2] ci: bump actions off deprecated Node 20 to Node 24 majors Every Actions run warned that checkout, upload-artifact, download-artifact and setup-uv target Node 20, which GitHub is retiring and currently forces onto a Node 24 shim. Pin each to its current Node 24 major: actions/checkout v4 -> v7 astral-sh/setup-uv v5 -> v10 actions/upload-artifact v4 -> v7 (release.yml) actions/download-artifact v4 -> v8 (release.yml) pypa/gh-action-pypi-publish is a container action, not Node-based, so it is untouched. The release upload/download handoff stays compatible: dist/ is a multi-file directory, so it is zipped on upload as before and download@v8 unzips it; v8's hash-mismatch-errors default is strictly safer. Co-Authored-By: Claude Opus 4.8 --- .github/workflows/ci.yml | 6 +++--- .github/workflows/release.yml | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 78c902f..507e835 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,10 +9,10 @@ jobs: verify: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v7 - name: Install uv - uses: astral-sh/setup-uv@v5 + uses: astral-sh/setup-uv@v10 with: enable-cache: true @@ -59,7 +59,7 @@ jobs: container: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v7 - name: Build image run: docker build -f Containerfile -t samplerdisc . diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 10d99b3..76ffbc9 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -26,10 +26,10 @@ jobs: build: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v7 - name: Install uv - uses: astral-sh/setup-uv@v5 + uses: astral-sh/setup-uv@v10 # The tag is the version, and a tag that disagrees with pyproject would # publish the wrong number under the right name. Fail loud instead — the @@ -50,7 +50,7 @@ jobs: - name: Check metadata renders run: uvx twine check dist/* - - uses: actions/upload-artifact@v4 + - uses: actions/upload-artifact@v7 with: name: dist path: dist/ @@ -62,7 +62,7 @@ jobs: permissions: id-token: write # OIDC token for Trusted Publishing; nothing else steps: - - uses: actions/download-artifact@v4 + - uses: actions/download-artifact@v8 with: name: dist path: dist/ From 0fd9d7c28680bc996c513cfd1be4262edeec514a Mon Sep 17 00:00:00 2001 From: Peter Tos <38345014+bmxcode@users.noreply.github.com> Date: Sat, 5 Sep 2026 22:13:11 +1000 Subject: [PATCH 2/2] ci: pin setup-uv to v10.0.1 (no floating v10 tag) astral-sh/setup-uv publishes floating major tags through v6 but not v10, so @v10 failed to resolve ("unable to find version v10"). Pin the exact v10.0.1, which is Node 24. The other three actions do publish floating majors (checkout@v7, upload-artifact@v7, download-artifact@v8), so those stay on the major tag. Co-Authored-By: Claude Opus 4.8 --- .github/workflows/ci.yml | 2 +- .github/workflows/release.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 507e835..3fe4a8b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -12,7 +12,7 @@ jobs: - uses: actions/checkout@v7 - name: Install uv - uses: astral-sh/setup-uv@v10 + uses: astral-sh/setup-uv@v10.0.1 with: enable-cache: true diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 76ffbc9..213cca4 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -29,7 +29,7 @@ jobs: - uses: actions/checkout@v7 - name: Install uv - uses: astral-sh/setup-uv@v10 + uses: astral-sh/setup-uv@v10.0.1 # The tag is the version, and a tag that disagrees with pyproject would # publish the wrong number under the right name. Fail loud instead — the