Skip to content

chore(release): v1.0.0-rc.6 - #2611

Merged
notgitika merged 2 commits into
refactorfrom
release/v1.0.0-rc.6
Oct 16, 2026
Merged

notgitika merged 2 commits into
refactorfrom
release/v1.0.0-rc.6

Conversation

@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Merging publishes @aws/agentcore@1.0.0-rc.6 to npm and creates the v1.0.0-rc.6 GitHub release with generated notes.

@github-actions github-actions Bot added the size/m PR size: M label Oct 16, 2026
nborges-aws
nborges-aws previously approved these changes Oct 16, 2026
notgitika
notgitika previously approved these changes Oct 16, 2026
@notgitika

Copy link
Copy Markdown
Contributor

Looking into failing CI

@codecov-commenter

codecov-commenter commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.58%. Comparing base (fdf9cf2) to head (57dcce2).
⚠️ Report is 1 commits behind head on refactor.

Additional details and impacted files
@@            Coverage Diff            @@
##           refactor    #2611   +/-   ##
=========================================
  Coverage     96.58%   96.58%           
=========================================
  Files           700      700           
  Lines         57638    57638           
=========================================
  Hits          55672    55672           
  Misses         1966     1966           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@notgitika

Copy link
Copy Markdown
Contributor

The verify failure on all three OSes is one test: FsProjectManager.create > scaffolds the expected file tree into a fresh directory (src/core/project/manager.test.ts:165).

expect(cdkPackage.dependencies["@aws/agentcore-cdk"]).toBe(MINIMUM_COMPATIBLE_CDK_VERSION);
Expected: "1.0.0-rc.3"
Received: "1.0.0-rc.4"

The scaffold asset (src/assets/cdk/package.json) pins @aws/agentcore-cdk at 1.0.0-rc.4, but MINIMUM_COMPATIBLE_CDK_VERSION in src/core/project/backends/cdk/compatibility.ts is still 1.0.0-rc.3 — the two drifted during the release bump. Fixing by bumping the constant to 1.0.0-rc.4 to match the pin (MIN_MIGRATED_FROM_CDK_VERSION is already rc.4).

Unblocks rc.6. Filing a follow-up to make this a single source of truth so the floor and scaffold pin can't drift again.

The scaffold asset pins @aws/agentcore-cdk at 1.0.0-rc.4 but the
compatibility floor was left at rc.3, drifting during the release bump
and failing manager.test.ts. Align the floor with the scaffolded pin.
@notgitika
notgitika dismissed stale reviews from nborges-aws and themself via 57dcce2 October 16, 2026 19:18
@github-actions github-actions Bot added size/m PR size: M and removed size/m PR size: M labels Oct 16, 2026
@notgitika
notgitika merged commit c480abb into refactor Oct 16, 2026
14 of 15 checks passed
@notgitika
notgitika deleted the release/v1.0.0-rc.6 branch October 16, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m PR size: M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants