From 0cd03dd3de23305af59cdc64b66759f49c1ebe53 Mon Sep 17 00:00:00 2001 From: joyboy-29 Date: Thu, 24 Sep 2026 17:54:24 +0000 Subject: [PATCH] Add actionable assertion messages to enums checks Fixes #105 - added descriptive messages to 13 bare assertions across enums1.py-enums6.py --- checks/enums/enums1.py | 6 +++--- checks/enums/enums2.py | 4 ++-- checks/enums/enums3.py | 4 ++-- checks/enums/enums4.py | 2 +- checks/enums/enums5.py | 6 +++--- checks/enums/enums6.py | 4 ++-- 6 files changed, 13 insertions(+), 13 deletions(-) diff --git a/checks/enums/enums1.py b/checks/enums/enums1.py index 244efe8..96600c3 100644 --- a/checks/enums/enums1.py +++ b/checks/enums/enums1.py @@ -1,4 +1,4 @@ -assert Color.RED.value == "red" -assert Color.BLUE.value == "blue" -assert favorite is Color.RED +assert Color.RED.value == "red","RED value should be 'red'" +assert Color.BLUE.value == "blue","BLUE value should be 'blue'" +assert favorite is Color.RED, "favorite should be color.RED" print("enums1 ok") diff --git a/checks/enums/enums2.py b/checks/enums/enums2.py index 7deb8fa..8d62d42 100644 --- a/checks/enums/enums2.py +++ b/checks/enums/enums2.py @@ -1,3 +1,3 @@ -assert [member.name for member in Status] == ["TODO", "DOING", "DONE"] -assert [member.value for member in Status] == [1, 2, 3] +assert [member.name for member in Status] == ["TODO", "DOING", "DONE"], "status member names should be TODO, DOING, DONE in order" +assert [member.value for member in Status] == [1, 2, 3], "status member values should be 1,2,3 in order" print("enums2 ok") diff --git a/checks/enums/enums3.py b/checks/enums/enums3.py index 0a7be71..58546ab 100644 --- a/checks/enums/enums3.py +++ b/checks/enums/enums3.py @@ -1,3 +1,3 @@ -assert selected_name == "HIGH" -assert selected_value == 5 +assert selected_name == "HIGH", "selected_name should be 'HIGH" +assert selected_value == 5, "selected_value should be 5" print("enums3 ok") diff --git a/checks/enums/enums4.py b/checks/enums/enums4.py index 1686e35..fda3e72 100644 --- a/checks/enums/enums4.py +++ b/checks/enums/enums4.py @@ -1,2 +1,2 @@ -assert size_codes == ["S", "M", "L"] +assert size_codes == ["S", "M", "L"], "size_codes should be ['S', 'M', 'L']" print("enums4 ok") diff --git a/checks/enums/enums5.py b/checks/enums/enums5.py index 0a6792a..ab638b8 100644 --- a/checks/enums/enums5.py +++ b/checks/enums/enums5.py @@ -1,4 +1,4 @@ -assert is_terminal(TicketState.OPEN) is False -assert is_terminal(TicketState.CLOSED) is True -assert is_terminal(TicketState.CANCELLED) is True +assert is_terminal(TicketState.OPEN) is False, "OPEN should not be terminal" +assert is_terminal(TicketState.CLOSED) is True, "CLOSED should be terminal" +assert is_terminal(TicketState.CANCELLED) is True, "CANCELLED should be terminal" print("enums5 ok") diff --git a/checks/enums/enums6.py b/checks/enums/enums6.py index bd6af35..a4bac84 100644 --- a/checks/enums/enums6.py +++ b/checks/enums/enums6.py @@ -1,3 +1,3 @@ -assert Direction.NORTH.delta() == (0, -1) -assert Direction.EAST.delta() == (1, 0) +assert Direction.NORTH.delta() == (0, -1), "NORTH delta should be (0, -1)" +assert Direction.EAST.delta() == (1, 0), "EAST delta should be(1, 0)" print("enums6 ok")