From e41cd71c2383d6ee9a1e549d540dd7d5286f9128 Mon Sep 17 00:00:00 2001 From: Sam Evans <47793072+Sevans711@users.noreply.github.com> Date: Mon, 24 Aug 2026 11:40:36 -0400 Subject: [PATCH 1/2] make PR template form more concise and clear --- .github/PULL_REQUEST_TEMPLATE.md | 64 ++++++++++++++------------------ 1 file changed, 28 insertions(+), 36 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index ea8d62327..1d4d66bd9 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,15 +1,22 @@ - + + +Closes #XXX -Closes #XXX + or "Fixes part of #YYY but does not fully close it." --> ## Overview - + + + + + ## Expected Usage + **General** - [ ] An issue is created and linked @@ -38,28 +45,21 @@ other_output = uxds.some_function(some_param = True) - [ ] Filled out Overview and Expected Usage (if applicable) sections **Testing & Benchmarking** - -- [ ] Adequate tests are created if there is new functionality -- [ ] Tests are not too basic (such as simply calling a function and nothing else) -- [ ] Tests cover all major paths in your new functions +- [ ] There is adequate test coverage of changes from this PR (add new tests if needed) - [ ] If this PR could affect performance, ran ASV benchmarks and confirmed they show expected behavior (add a new benchmark if necessary) **Documentation** - -- [ ] Docstrings have been added to all new functions -- [ ] Docstrings have been updated with any function changes -- [ ] User (public) functions have been added to `docs/api.rst` -- [ ] Internal (private) function names start with an underscore (`_`) +- [ ] Docstrings updated with any function changes, and included in all new functions +- [ ] User (public) functions added to `docs/api.rst`; internal (private) function names start with an underscore (`_`) **Examples** - -- [ ] **All** notebook examples cleared the output of all cells before committing -- [ ] New notebook examples added to appropriate folder (gallery: `docs/examples/`; guide: `docs/user-guide/`; quickstart: `docs/getting-started/`) -- [ ] New notebook examples referenced in appropriate .rst file (gallery: `docs/gallery.rst`; guide: `docs/userguide.rst`; quickstart: `docs/quickstart.rst`) -- [ ] New notebook gallery examples added entry in `docs/gallery.yml` with appropriate thumbnail photo in `docs/_static/thumbnails/` +- [ ] If touched any notebook examples, cleared the output of all cells before committing +- [ ] If added new notebook examples, put in appropriate folder(s) and referenced in appropriate docs files + ## AI Disclosure @@ -71,19 +71,11 @@ other_output = uxds.some_function(some_param = True) AI Usage: -- [ ] I take responsibility for all AI-generated content in my PR. -- [ ] I have tested all AI-generated content in my PR. - - From 76793f53ea944240b5347c91b4aaa81c58bede1b Mon Sep 17 00:00:00 2001 From: Sam Evans <47793072+Sevans711@users.noreply.github.com> Date: Wed, 26 Aug 2026 15:01:52 -0400 Subject: [PATCH 2/2] put example notebook details in contributors guide and remove those details from pr template form. pr template form now links to the relevant part of that docs page instead of providing all details inline. Also, merges Documentation with Examples section in pr checklist, and edits examples language slightly. --- .github/PULL_REQUEST_TEMPLATE.md | 14 +++++--------- docs/contributing.rst | 21 +++++++++++++++++---- 2 files changed, 22 insertions(+), 13 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 1d4d66bd9..9a9d8f913 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -50,17 +50,13 @@ other_output = uxds.some_function(some_param = True) -**Documentation** +**Documentation and Examples** - [ ] Docstrings updated with any function changes, and included in all new functions - [ ] User (public) functions added to `docs/api.rst`; internal (private) function names start with an underscore (`_`) - -**Examples** -- [ ] If touched any notebook examples, cleared the output of all cells before committing -- [ ] If added new notebook examples, put in appropriate folder(s) and referenced in appropriate docs files - - +- [ ] If touched any notebook files, cleared the output of all cells before committing +- [ ] If added new notebook files, put into appropriate directories and referenced in appropriate files + ## AI Disclosure