From 7e3a6b5ac7fd09b96b820c8a0cbb277157e14d67 Mon Sep 17 00:00:00 2001 From: Dan Cormier Date: Wed, 20 May 2026 12:11:37 -0400 Subject: [PATCH 1/4] fix(docs): resolve accessibility report issues --- packages/stacks-docs/src/app.css | 1 + packages/stacks-docs/src/components/BannerPreview.svelte | 2 +- packages/stacks-docs/src/components/ClassTable.svelte | 2 +- packages/stacks-docs/src/docs/public/system/base/overflow.md | 2 +- .../stacks-docs/src/docs/public/system/components/buttons.md | 4 +++- .../public/system/components/buttons/AnchorButtonTable.svelte | 2 +- packages/stacks-docs/src/routes/+page.svelte | 2 +- 7 files changed, 9 insertions(+), 6 deletions(-) diff --git a/packages/stacks-docs/src/app.css b/packages/stacks-docs/src/app.css index 7d3f7fc100..bbb40e062d 100644 --- a/packages/stacks-docs/src/app.css +++ b/packages/stacks-docs/src/app.css @@ -478,6 +478,7 @@ h1 { list-style: none; } .docs-link { + color: var(--theme-link-color, var(--black-600)); font-weight: 500; } diff --git a/packages/stacks-docs/src/components/BannerPreview.svelte b/packages/stacks-docs/src/components/BannerPreview.svelte index 568c03573f..1aeddab40a 100644 --- a/packages/stacks-docs/src/components/BannerPreview.svelte +++ b/packages/stacks-docs/src/components/BannerPreview.svelte @@ -24,6 +24,6 @@ Stacks is currently frozen in read-only mode. Contact the team to restore access.
- +
diff --git a/packages/stacks-docs/src/components/ClassTable.svelte b/packages/stacks-docs/src/components/ClassTable.svelte index c6a6381676..ac57fef385 100644 --- a/packages/stacks-docs/src/components/ClassTable.svelte +++ b/packages/stacks-docs/src/components/ClassTable.svelte @@ -117,7 +117,7 @@ {:else} {@const val = String((row as Record)[col] ?? '')} {#if val === 'N/A'} - N/A + N/A {:else if val.startsWith('.')} {val} {:else} diff --git a/packages/stacks-docs/src/docs/public/system/base/overflow.md b/packages/stacks-docs/src/docs/public/system/base/overflow.md index 53c3ce0615..e60971268d 100644 --- a/packages/stacks-docs/src/docs/public/system/base/overflow.md +++ b/packages/stacks-docs/src/docs/public/system/base/overflow.md @@ -82,7 +82,7 @@ description: Atomic overflow classes allow you to change an element's overflow p ``` -
+
.overflow-auto
diff --git a/packages/stacks-docs/src/docs/public/system/components/buttons.md b/packages/stacks-docs/src/docs/public/system/components/buttons.md index 0dee0b6a3a..6e8c08c2b4 100644 --- a/packages/stacks-docs/src/docs/public/system/components/buttons.md +++ b/packages/stacks-docs/src/docs/public/system/components/buttons.md @@ -201,7 +201,9 @@ Each button class has a selected state which can be visually activated by applyi ``` - + + + ## Additional styles diff --git a/packages/stacks-docs/src/docs/public/system/components/buttons/AnchorButtonTable.svelte b/packages/stacks-docs/src/docs/public/system/components/buttons/AnchorButtonTable.svelte index 17e1dc4a1e..f060444c29 100644 --- a/packages/stacks-docs/src/docs/public/system/components/buttons/AnchorButtonTable.svelte +++ b/packages/stacks-docs/src/docs/public/system/components/buttons/AnchorButtonTable.svelte @@ -51,7 +51,7 @@ - + diff --git a/packages/stacks-docs/src/routes/+page.svelte b/packages/stacks-docs/src/routes/+page.svelte index 840ceff791..5e88d60c8c 100644 --- a/packages/stacks-docs/src/routes/+page.svelte +++ b/packages/stacks-docs/src/routes/+page.svelte @@ -61,7 +61,7 @@ >

{category.title}

-

{category.description}

+

{category.description}

{/each} From f122b6389dff522fe3749db8c0a928823663ccb1 Mon Sep 17 00:00:00 2001 From: Dan Cormier Date: Mon, 29 Jun 2026 14:59:02 -0400 Subject: [PATCH 2/4] Update packages/stacks-docs/src/app.css MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Andrea Sánchez Blanco --- packages/stacks-docs/src/app.css | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/stacks-docs/src/app.css b/packages/stacks-docs/src/app.css index bbb40e062d..9b3a9b1864 100644 --- a/packages/stacks-docs/src/app.css +++ b/packages/stacks-docs/src/app.css @@ -477,10 +477,14 @@ h1 { .docs-nav .docs-li { list-style: none; } +.docs-link { +.docs-copy .docs-link, .docs-link { color: var(--theme-link-color, var(--black-600)); font-weight: 500; } + font-weight: 500; +} /* Style for some columns we want a strike through */ From 63644badfddf9d92a13f3271e72601a6f7ea34ae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andrea=20S=C3=A1nchez=20Blanco?= Date: Wed, 5 Aug 2026 14:27:22 +0200 Subject: [PATCH 3/4] fix(docs): restore prose link contrast --- packages/stacks-docs/src/app.css | 3 --- 1 file changed, 3 deletions(-) diff --git a/packages/stacks-docs/src/app.css b/packages/stacks-docs/src/app.css index d138e36d23..ff89ace739 100644 --- a/packages/stacks-docs/src/app.css +++ b/packages/stacks-docs/src/app.css @@ -477,14 +477,11 @@ h1 { .docs-nav .docs-li { list-style: none; } -.docs-link { .docs-copy .docs-link, .docs-link { color: var(--theme-link-color, var(--black-600)); font-weight: 500; } - font-weight: 500; -} /* Style for some columns we want a strike through */ From cc92b8dccea5dc609b8ff3e34ca264c28b0701eb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andrea=20S=C3=A1nchez=20Blanco?= Date: Wed, 5 Aug 2026 14:27:29 +0200 Subject: [PATCH 4/4] fix(docs): keep anchor examples as links --- .../system/components/buttons/AnchorButtonTable.svelte | 2 +- .../stacks-svelte/src/components/Button/Button.test.ts | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/stacks-docs/src/docs/public/system/components/buttons/AnchorButtonTable.svelte b/packages/stacks-docs/src/docs/public/system/components/buttons/AnchorButtonTable.svelte index f060444c29..f0b128c3c6 100644 --- a/packages/stacks-docs/src/docs/public/system/components/buttons/AnchorButtonTable.svelte +++ b/packages/stacks-docs/src/docs/public/system/components/buttons/AnchorButtonTable.svelte @@ -51,7 +51,7 @@ - + diff --git a/packages/stacks-svelte/src/components/Button/Button.test.ts b/packages/stacks-svelte/src/components/Button/Button.test.ts index dc8b16252e..a5f98dc5b6 100644 --- a/packages/stacks-svelte/src/components/Button/Button.test.ts +++ b/packages/stacks-svelte/src/components/Button/Button.test.ts @@ -21,6 +21,13 @@ describe("Button", () => { expect(screen.getByRole("link")).to.have.text("test btn"); }); + it("should preserve link semantics when selected", () => { + render(Button, { href: "#", selected: true, children }); + + expect(screen.getByRole("link")).not.to.have.attribute("aria-pressed"); + expect(screen.queryByRole("button")).not.to.exist; + }); + it("should render the badge within the button", () => { render(Button, { children,