Skip to content

oj dependency breaks support for JRuby #1461

Description

@headius

Issue summary

Before opening this issue, I have:

  • Upgraded to the latest version of the package
    • shopify_api version:
    • Ruby version:
    • Operating system:
  • [ ] Set log_level: :debug in my configuration, if applicable
  • Found a reliable way to reproduce the problem that indicates it's a problem with the package
  • Looked for similar issues in this repository
  • [ ] Checked that this isn't an issue with a Shopify API

Expected behavior

The gem should install.

Actual behavior

The gem does not install because the oj dependency requires C extension support.

Steps to reproduce the problem

  1. Run gem install shopify_api on JRuby

Debug logs

 $ gem install shopify_api
Fetching oj-3.17.6.gem
Fetching shopify_api-16.3.0.gem
Fetching sorbet-runtime-0.6.13466.gem
Fetching openssl-4.0.2-java.gem
Fetching hash_diff-1.1.1.gem
Fetching httparty-0.24.2.gem
Successfully installed sorbet-runtime-0.6.13466
Successfully installed openssl-4.0.2-java
Building native extensions. This could take a while...
ERROR:  Error installing shopify_api:
	ERROR: Failed to build gem native extension.

    current directory: /Users/headius/work/jruby/lib/ruby/gems/shared/gems/oj-3.17.6/ext/oj

The dependency on oj is both problematic and unnecessary; the json library has been greatly optimized over the past couple of years, and there's little reason to depend upon an external library anymore. Further, json also includes optimized support for JRuby.

I suggest removing the oj dependency and just using json.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    devtools-gardenerPost the issue or PR to Slack for the gardener

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions