Repository navigation
[Fix] Reasoning label changes when users move the DeepSeek picker - #3427
Merged
Merged
Conversation
Contributor
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
October 7, 2026 09:55
brunobergher
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
medium.mediumandxhighrequest High, matching DeepSeek's documented mapping. Cover current and retained Vercel/OpenCode Go route aliases, and carry the underlying model ID through Same as coding model options.Why this change was made
The session chip displayed the raw configured
medium, while the slider used the model's published['low', 'high', 'max']stops. An unsupported inherited default fell back to the middle stop (High); returning there after a slider change emittedhigh, changing the chip's label. An explicit legacymediumtook a separate nearest-level path that could even display Low on a distance tie. The provider already maps Medium to High, so inventing a distinct Medium stop would misrepresent the model.Impact
mediumdefaultmedium; session stays inheritedhighprovider optionmediumoverridemediumuntil editedhighprovider optionhighoverridehighmaxoverridemaxOther model defaults and existing fallback selection policy remain unchanged; no database migration or automatic rewrite of saved choices is needed.
The new session regression failed on the original code (chip read
DeepSeek V4.1 FlashMedium) and passes with the fix. Targeted web/settings/catalog/session-command tests passed (160 tests), as did targeted types/provider/config tests (153 tests); the affected picker/settings suites were rerun after the final adjustment (84 tests).pnpm lint:fast,pnpm check-types:fast,pnpm knip, and the commit/push hooks passed.mise exec -- pnpm --filter @roomote/docs checkpassed, and the updated docs page rendered in the local preview.Browser proof capture exceeded its shared deadline (
proof capture timed out); no visual proof is included. Provider-effective effort is grounded in official documentation and provider-option regression checks; no live billable model generation was sampled.