Skip to content

Refactor: Remove Decorator<T> and replace with Scrutor #70

Description

@JoStevensRSK

The repository currently contains two copies of a custom DI decorator implementation:

  • src/Open.IdentityServer/src/Configuration/DependencyInjection/Decorator.cs
  • src/AspNetIdentity/src/Decorator.cs

The associated AddDecorator<TService> and
AddTransientDecorator<TService, TImplementation> helpers manually manipulate
IServiceCollection registrations and handle implementation types, instances,
factories, and disposal.

Replace this custom implementation with the Scrutor library.

Decorated services

The following services currently use the custom decorator mechanism:

  • IAuthenticationService
    • IdentityServerAuthenticationService
  • IAuthenticationHandlerProvider
    • FederatedSignoutAuthenticationHandlerProvider
  • ICorsPolicyProvider
    • CorsPolicyProvider
  • IUserClaimsPrincipalFactory<TUser>
    • UserClaimsFactory<TUser>

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    Fields

    Priority

    Low

    Effort

    Medium

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions