Repository navigation
feat: carry each chart mapping's framework - #226
Conversation
Regenerated against robosystems#1608, which anchors each coa_mapping structure to a mapping taxonomy the chart owns: - TaxonomyBlockStructureRequest / TaxonomyBlockStructure gain an optional target_framework (coa_mapping only) - the GraphQL Structure type gains framework; LedgerClient.list_mappings and list_structures now return it, the book mapping listed first Claude-Session: https://claude.ai/code/session_01HdEHDANCXBjrPfKagNDgSB
|
@claude please review this PR |
|
Claude finished @jfrench9's task in 58s —— View job Review complete
Verdict: LGTM. This is a clean, well-scoped additive change. What I checked:
Nit (non-blocking): the Note: I was unable to run |
Summary
Picks up robosystems#1608, which anchors each chart mapping to a
mappingtaxonomy the chart owns and records the framework it maps into. The regenerated models carry the new optional field, andLedgerClientnow returns each mapping'sframework.Release order: publish only after robosystems#1608 is deployed.
list_mappingsandlist_structuresnow selectframework, and a server without that field rejects the query.Changes
robosystems_client/models/):TaxonomyBlockStructureRequestandTaxonomyBlockStructuregain an optionaltarget_framework, used only oncoa_mappingstructures; omitted means the book framework. The regen picked up only this change, with no other drift since the last generation.robosystems_client/graphql/):schema.graphqlis refreshed; theStructuretype gainsframework.ListLedgerMappingsandListLedgerStructuresoperations select it.generated/is regenerated from those operations.clients/ledger_client.py):list_mappingsandlist_structuresreturnframework.list_mappingsdocstring says the book mapping is listed first.tests/test_ledger_client.py): the two fixtures carryframework, andlist_mappingsasserts it.Compatibility
ADDITIVE: a client minor. The new REST model fields are optional, and
frameworkis a new, nullable field on two facade return types. No export, signature or existing field changed.Deploy-order dependency: the two facade queries request a field that only exists once robosystems#1608 is deployed. Against an older server they fail GraphQL validation, so this has to be published after that deploy.
Testing
just generate-sdkagainst the local stack running robosystems#1608's branch. The branch was current withmain, and the new fields were confirmed in the live/openapi.jsonand GraphQL schema first.just generate-graphqlwas run after the operation edits.just test-all: 595 passed, 17 skipped; ruff and format clean; basedpyright 0 errors.just build-packagewas not run (no packaging change).🤖 Generated with Claude Code