Skip to content

Consider only attempting signing if shouldSign is explicity true or auto in EsrpSign.yml #24

Description

By assuming shouldSign is false unless explicitly auto or true, will help prevent accidentally signing binaries unless the user explicitly wanted them signed. I would also consider setting the shouldSign parameter to false as default, but that would be a bigger breaking change.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions