communities: render earlier event markers on top - #1124
Merged
Merged
Conversation
Event markers were stacked purely by fetch order, so a later event could cover an earlier one sharing the same location. Sort events descending by start_at so the earliest events' markers are added last and render on top.
✅ Deploy Preview for pauseai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On the /communities map, event markers are now sorted descending by
start_atbefore being added to the map, so the earliest events' markers render on top of later ones.Why
MapLibre stacks markers by DOM insertion order (later-added markers render on top). Events were previously added in fetch order, which could cover an earlier event's marker with a later event's marker when they share the same location.
Reviewer notes
src/routes/communities/+page.svelte; community markers are unaffected.