From acf38041df405d3801acf5525831207eb221d7df Mon Sep 17 00:00:00 2001 From: Edwin Gonzales Date: Mon, 21 Sep 2026 13:51:57 +0800 Subject: [PATCH 1/2] test(spp_gis): assert the geofence GeoJSON core properties as a subset, not an exact set test_to_geojson_properties_structure asserted that incident_id and incident_name are absent. spp_api_v2_gis legitimately adds both to the same properties and asserts their presence in its own tests, so any database carrying both modules failed one suite or the other. The core contract is that its own keys are present; downstream extensions are allowed. Refs #443 --- spp_gis/__manifest__.py | 2 +- spp_gis/readme/HISTORY.md | 4 ++++ spp_gis/tests/test_geofence.py | 6 ++---- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/spp_gis/__manifest__.py b/spp_gis/__manifest__.py index d57d1c4f6..66e4ec9bb 100644 --- a/spp_gis/__manifest__.py +++ b/spp_gis/__manifest__.py @@ -4,7 +4,7 @@ { "name": "OpenSPP GIS", "category": "OpenSPP/Core", - "version": "19.0.2.1.0", + "version": "19.0.2.1.1", "sequence": 1, "author": "OpenSPP.org", "website": "https://github.com/OpenSPP/OpenSPP2", diff --git a/spp_gis/readme/HISTORY.md b/spp_gis/readme/HISTORY.md index 4d10b22fd..6cdd769cc 100644 --- a/spp_gis/readme/HISTORY.md +++ b/spp_gis/readme/HISTORY.md @@ -1,3 +1,7 @@ +### 19.0.2.1.1 + +- test(gis): the geofence GeoJSON properties test asserts the core keys are present and no longer asserts that the incident keys are absent. `spp_api_v2_gis` legitimately adds `incident_id`/`incident_name` to the same properties (and asserts their presence in its own tests), so the absence check failed on every database carrying both modules. No behaviour change (#443) + ### 19.0.2.1.0 - feat: spatial operators support MultiPolygon and GeometryCollection, including distance buffering (re-land from #76). diff --git a/spp_gis/tests/test_geofence.py b/spp_gis/tests/test_geofence.py index 15347849d..4ea285add 100644 --- a/spp_gis/tests/test_geofence.py +++ b/spp_gis/tests/test_geofence.py @@ -224,10 +224,8 @@ def test_to_geojson_properties_structure(self): self.assertIn("created_from", props) self.assertIn("created_by", props) self.assertIn("create_date", props) - - # Should NOT have incident fields in core - self.assertNotIn("incident_id", props) - self.assertNotIn("incident_name", props) + # Downstream modules may extend the properties (spp_api_v2_gis adds the + # incident fields), so the core contract is a subset, not an exact set. def test_to_geojson_collection(self): """Test converting multiple geofences to GeoJSON FeatureCollection.""" From 109033fbec810253032313ae3b06eaaf8c8a1aa8 Mon Sep 17 00:00:00 2001 From: Edwin Gonzales Date: Mon, 21 Sep 2026 14:12:04 +0800 Subject: [PATCH 2/2] docs(spp_gis): regenerate README from fragments (CI output) --- spp_gis/README.rst | 10 ++++++++++ spp_gis/static/description/index.html | 13 ++++++++++++- 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/spp_gis/README.rst b/spp_gis/README.rst index 1263d1ecd..bc79481b1 100644 --- a/spp_gis/README.rst +++ b/spp_gis/README.rst @@ -140,6 +140,16 @@ External Python libraries: ``shapely``, ``pyproj``, ``geojson`` Changelog ========= +19.0.2.1.1 +~~~~~~~~~~ + +- test(gis): the geofence GeoJSON properties test asserts the core keys + are present and no longer asserts that the incident keys are absent. + ``spp_api_v2_gis`` legitimately adds ``incident_id``/``incident_name`` + to the same properties (and asserts their presence in its own tests), + so the absence check failed on every database carrying both modules. + No behaviour change (#443) + 19.0.2.1.0 ~~~~~~~~~~ diff --git a/spp_gis/static/description/index.html b/spp_gis/static/description/index.html index c4d333a6b..645589516 100644 --- a/spp_gis/static/description/index.html +++ b/spp_gis/static/description/index.html @@ -518,6 +518,17 @@

Changelog

+

19.0.2.1.1

+
    +
  • test(gis): the geofence GeoJSON properties test asserts the core keys +are present and no longer asserts that the incident keys are absent. +spp_api_v2_gis legitimately adds incident_id/incident_name +to the same properties (and asserts their presence in its own tests), +so the absence check failed on every database carrying both modules. +No behaviour change (#443)
  • +
+
+

19.0.2.1.0

  • feat: spatial operators support MultiPolygon and GeometryCollection, @@ -532,7 +543,7 @@

    19.0.2.1.0

    onto spp.gis.geofence.tag records when upgrading from 19.0.2.0.x.
-
+

19.0.2.0.0

  • Initial migration to OpenSPP2