Skip to content

Rebalance the workflow health grid - #5178

Merged
lmac-1 merged 1 commit into
release-2.19.0from
workflow-health-styling-tweak
Sep 14, 2026
Merged

lmac-1 merged 1 commit into
release-2.19.0from
workflow-health-styling-tweak

Conversation

@lmac-1

@lmac-1 lmac-1 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Triage and Runs over time take three columns at xl, the donuts one. At lg it's a five-column split, so the wide cards still get more room. The failure breakdown card no longer stretches to the triage table, and each donut sits with its legend in a capped, centred column.

Validation steps

  1. Load workflow health page

Additional notes for the reviewer

  1. n/a

AI Usage

Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

Pre-submission checklist

  • I have performed an AI review of my code (we recommend using /review
    with Claude Code)
  • I have implemented and tested all related authorization policies.
    (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

Triage and Runs over time take three columns at xl, the donuts one.
At lg it's a five-column split, so the wide cards still get more room.
The failure breakdown card no longer stretches to the triage table,
and each donut sits with its legend in a capped, centred column.
@github-project-automation github-project-automation Bot moved this to New Issues in Core Sep 14, 2026
@lmac-1
lmac-1 merged commit 15e23fc into release-2.19.0 Sep 14, 2026
1 of 2 checks passed
@lmac-1
lmac-1 deleted the workflow-health-styling-tweak branch September 14, 2026 09:33
@github-project-automation github-project-automation Bot moved this from New Issues to Done in Core Sep 14, 2026
@github-actions

Copy link
Copy Markdown

Security Review ✅

  • S0 (project scoping): All new server work (lifecycle_state/2, save_workflow, list_sandboxes, dashboard lifecycle column) keys off socket.assigns.workflow_id/project established at join by WorkflowResolver.resolve and resolve_snapshot, which still enforce check_ownership (lib/lightning/collaboration/workflow_resolver.ex:294); the resolver rework preserves that gate.
  • S1 (authorization): New go_live / switch_to_draft handlers gate on authorize_edit_workflow/1 before touching the row (lib/lightning_web/channels/workflow_channel.ex:1880), server-side Yjs frame forwarding now also refuses workflow_kind: :version (workflow_channel.ex:1848), and Session.do_save_workflow refuses every write mode when view_only?: true (lib/lightning/collaboration/session.ex:465) — covering save/reset/set_state at one chokepoint.
  • S2 (audit trail): Lifecycle changes flow through Workflows.go_live/switch_to_draft/restore_versionsave_workflow, whose Multi still writes Audit.snapshot_created and Audit.workflow_state_changed (lib/lightning/workflows.ex:743, :766); no new config-resource writes bypass that path.

@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-2.19.0@d2bb89c). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-2.19.0   #5178   +/-   ##
================================================
  Coverage                  ?   91.1%           
================================================
  Files                     ?     427           
  Lines                     ?   21707           
  Branches                  ?       0           
================================================
  Hits                      ?   19780           
  Misses                    ?    1927           
  Partials                  ?       0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant