Byte-Range (with value 1-0/0) is not included in bodiless SENDs

[optimusprime01]

According to RFC 4975:
There are some circumstances where an endpoint may choose to send an empty SEND request. For the sake of consistency, a Byte-Range header field referring to nonexistent or zero-length content MUST still have a range-start value of 1. For example, "1-0/0".

However Transaction.makeSendHeader() doesn't include the Byte-Range: 1-0/0 header when content in OutgoingMessage is null.

[tuijldert]

Hi,

Thanks for the observation.
The paragraph above in the RFC states that the first chunk SHOULD include a byte-range, so technically, we're still correct and an empty SEND can still omit a byte-range header.
However, for less less forgiving peers and consistencies' sake it is better to include it.
Hence the linked commit, use at your own risk :).
Let me know how it goes so I can close this issue.

Hope this helps,
Tom.

[optimusprime01]

Hi Tom,
I was hoping to contribute to this repo and fix this myself. I had the same fix ready to be checked-in.
What is the process for contributing to this project? I work on a tool which uses an older version of this library. I have made my own enhancements to it and was looking to add those enhancements here.

[tuijldert]

Hi Sachin, � Nice. And your contributions are always welcome. The process is the standard one on github[1]. Just clone the repo to your own, commit the changes and offer them in a pull-request. We do not guarantee a swift handling of it (time is limited) but it’ll get there. � Hope this helps, Tom. � [1] https://gist.github.com/MarcDiethelm/7303312 � � From: Sachin Sunder Sagadevan <notifications@github.com> Sent: 21 August 2020 18:57 To: MSRP-OSS/msrp-java <msrp-java@noreply.github.com> Cc: Tom Uijldert <tom.uijldert@gmail.com>; Assign <assign@noreply.github.com> Subject: Re: [MSRP-OSS/msrp-java] Byte-Range (with value 1-0/0) is not included in bodiless SENDs (#21) � Hi Tom, I was hoping to contribute to this repo and fix this myself. I had the same fix ready to be checked-in. What is the process for contributing to this project? I work on a tool which uses an older version of this library. I have made my own enhancements to it and was looking to add those enhancements here. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#21 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA37QOL557V6NYDUYIMCRFDSB2RNVANCNFSM4QA3GG5A> .

[joantune]

I'll also try to help review things! at least code-wise reviewing as I have limited times to set up things. Feel free to submit your PRs Sachin! that way you'll assure future changes and enhancements to this library will include your changes. And thanks for contributing in advance

…

On Sat, Aug 22, 2020 at 8:06 AM Tom Uijldert ***@***.***> wrote: Hi Sachin, � Nice. And your contributions are always welcome. The process is the standard one on github[1]. Just clone the repo to your own, commit the changes and offer them in a pull-request. We do not guarantee a swift handling of it (time is limited) but it’ll get there. � Hope this helps, Tom. � [1] https://gist.github.com/MarcDiethelm/7303312 � � From: Sachin Sunder Sagadevan ***@***.***> Sent: 21 August 2020 18:57 To: MSRP-OSS/msrp-java ***@***.***> Cc: Tom Uijldert ***@***.***>; Assign < ***@***.***> Subject: Re: [MSRP-OSS/msrp-java] Byte-Range (with value 1-0/0) is not included in bodiless SENDs (#21) � Hi Tom, I was hoping to contribute to this repo and fix this myself. I had the same fix ready to be checked-in. What is the process for contributing to this project? I work on a tool which uses an older version of this library. I have made my own enhancements to it and was looking to add those enhancements here. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub < #21 (comment)> , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AA37QOL557V6NYDUYIMCRFDSB2RNVANCNFSM4QA3GG5A> . — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#21 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHYGBFUMWNDTPV4ZSEWUFLSB5N7JANCNFSM4QA3GG5A> .