Skip to content

fix(skill-eval): preserve same-plan results after disabling execution - #230

Merged
Dong1017 merged 1 commit into
mainfrom
fix/issue215-retain-paid-evidence
Oct 28, 2026
Merged

Dong1017 merged 1 commit into
mainfrom
fix/issue215-retain-paid-evidence

Conversation

@Dong1017

Copy link
Copy Markdown
Collaborator

Refs #215

A free label-removal/duplicate event currently replaces retained results with PLANNED. Use the verified budget ledger's complete plan digest and attempt-1 source run to recover existing evidence, then pass through the unchanged source-run and original-plan authentication. No provider call or ledger write is added. Changed plans remain stale; unavailable configured ledgers or invalid run provenance fail closed.

flowchart LR
 A[Unpaid event] --> B[Verified ledger exact-plan lookup]
 B --> C[Authenticate source run and original plan]
 C --> D[Retain existing evidence]
 B --> E[Different plan: no evidence inheritance]
Loading

17 offline retention cases cover removal/duplicates, changed head/base/version/exam, pending/forged run, unsafe/ambiguous ledger and unconfigured PRs. Local full suite: 2,325 passed, 3 skipped, 183 subtests; final 250 focused tests include two subsequently added cases. Ruff/diff-check passed. Independent review of patch SHA256 9721033abe1f3763b9e8ee129755b4ee547adee74160d876584b2ce1e0c23520 found no blocker.

Refresh usage/deployment docs with actual #159/#160 evidence, conservative unresolved reservations, #179 closure and Phase 2 deferral. This deployment changes implementation identity: earlier real-run plans stay historical, not rebound to the new implementation. Retention behavior is offline-tested; no additional paid run is claimed or requested.

AI assistance: OpenAI Codex; exact runtime model/effort identifiers unavailable. Tooling/tests/docs only, no knowledge-source authoring.

Use verified ledger bindings to locate existing same-plan evidence without additional execution. Update bounded live rollout documentation.

Agent-assisted-by: OpenAI Codex
Signed-off-by: Dong1017 <55723162+Dong1017@users.noreply.github.com>
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Skill evaluation

Automatic execution / cumulative PR budget: {"reason":"Audited PR ledger missing, unavailable or unsafe","remaining_usd":"unknown","reserved_or_unresolved_usd":"unknown","spent_or_legacy_usd":"unknown","state":"blocked"}

Advisory: obtain missing evidence

Retained evidence availability: planned / unexecuted. No approval or merge authorization is issued.

  • Retained evidence is planned / unexecuted.
  • No supported comparison cases were selected.
  • Uncovered/unsupported scope needs a case or explicit reviewer disposition.

PLANNED: execution is not authorized by knowing this hash.
Outcomes: {"fix":0,"inconclusive":0,"missing_pair":0,"regression":0,"unchanged_correct":0,"unchanged_incorrect":0}
Earlier revision results are stale for this plan.

Selected comparisons: 0 · Estimated task calls: 0.
Uncovered/unsupported changes: 5. Gaps never count as passes.

Applicable only while these revisions and inputs match the current PR.
Paid execution requires trusted label authorization and cumulative PR reservation. Unknown accounting blocks new paid calls; planning is not execution.
Pipeline evidence only; offline fixed outputs do not establish skill efficacy.
Evidence and logs · Retention: 30 days.
Outcomes are historical; verifiable only before Unix time 1795789452 while the linked artifact is available. Expired evidence is unverified.

Plan bindings, budget, frozen exam and advisory details

Unchanged-correct is valid neutral evidence, not incremental benefit.
Content/source review and authorship admission remain separate.
Trusted regrading checks retained answers, not model/hardware provenance or a hostile executor; this is not an efficacy certification.

Per-case outcomes (discovery excluded; regressions and gaps first):

[]

Showing at most 20 of 0 pairs; the evidence link contains all outcomes, including omitted regressions/gaps.

Plan SHA-256: 9612bcfa874090b266b6db49dbec2aacb5eb57c2674c1346e4ebb3d284399ca5
Base: fbc9d580d8e536480cd33e965e0c2af0085dcdc4 · Head: a60dea972aa71defb5e0d1366279326316f58426
Trusted implementation: fbc9d580d8e536480cd33e965e0c2af0085dcdc4

Model/settings: {"effort":"not_applicable","name":"claude-opus-5-5"}
Budget: {"comparisons":0,"estimated_calls":0,"limits_per_comparison":{"campaign_seconds":600,"max_task_calls":2,"repeats":1,"timeout_seconds":180,"token_stop_new_trials":200000},"provider_config_sha256":"253cf88a7ff04311fd1dae897cb68a8c986f136e837dd00dbe5f8872bd094b5f","reservation":null}

Skill Comparison Cases Estimated calls

Provider/settings: {"client":{"api_version":"2023-06-01","endpoint":"https://yibuapi.com/v1/messages","kind":"anthropic-messages-agent-v1","max_output_tokens":4096,"max_read_bytes":32768,"max_request_bytes":131072,"max_requests":6,"max_tool_calls":12,"provider":"yibuapi"},"limits":{"token_stop_new_trials":200000},"model":{"effort":"not_applicable","name":"claude-opus-5-5"},"pricing":{"currency":"USD","expires_at":1793271228,"group":"default","max_input_tokens":1000000,"model":"claude-opus-5-5","rate_evidence":"https://github.com/InferMatrixLab/InferRSI/issues/215#issuecomment-6467531341","rates":{"cache_read":"0.4","cache_write":"10","input":"8","output":"40"},"request_fee":"0","unit":"per_million_tokens"},"spend_limit":{"amount":"200","currency":"USD"}}

Uncovered / unsupported paths (5)
  • uncovered: "docs/skill-eval-deployment-215.md"
  • uncovered: "docs/skill-eval-pr.md"
  • uncovered: "tests/test_skill_eval_retention.py"
  • uncovered: "tools/skill_eval_auto.py"
  • uncovered: "tools/skill_eval_pr.py"

@Dong1017
Dong1017 marked this pull request as ready for review October 28, 2026 14:23
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T14:25:02.090988Z a60dea9 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Dong1017 Dong1017 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent software review found no blocking defects at a60dea9, base fbc9d58. All five remote blob hashes match the reviewed patch. Verified ledger lookup is read-only, keyed by the complete plan fingerprint, and still passes source-run and original-plan authentication; changed plans cannot inherit evidence.

17 retention cases cover label removal/unpaid duplicates and invalid/missing/stale provenance. Local full suite passed 2,325 tests with 3 skips; final 250 focused tests include two later-added cases. Independent reruns: 200 related tests plus 17 final retention cases. Latest Ready CI 40705480265 and declaration 40705480907 passed; automated review reports no findings.

Docs accurately retain #159/#160 historical results and unresolved conservative reservations. This implementation change does not rebind those old plans; same-plan preservation is offline-tested, with no extra paid run or efficacy assertion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant