You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The docs state that http.compressionThreshold defaults to 1200 bytes, so Brotli response compression is on out of the box. Harper's shipped configuration sets it to 0, and the runtime treats 0 as "off" — so on a default install, Brotli response compression never happens.
The root cause is not in this repo. Harper contradicts itself, and our docs faithfully mirror the half of it that isn't what actually ships.
Evidence (harper origin/main)
Location
Says
config-root.schema.json:25-31
property description: "Responses larger than this threshold (bytes) will be compressed... Default: 1200"
config-root.schema.json:774
examples block: "compressionThreshold": 1200
static/defaultConfig.yaml:4
compressionThreshold: 0 — this is what gets written into a new install's config
validation/configValidator.ts:329
compressionThreshold: number.optional() — no default injected
server/serverHelpers/contentTypes.ts:362
const COMPRESSION_THRESHOLD = envMgr.get(CONFIG_PARAMS.HTTP_COMPRESSIONTHRESHOLD) — no || fallback, so a configured 0 stays 0
server/serverHelpers/contentTypes.ts:373
canCompress = COMPRESSION_THRESHOLD && request.headers...includes('br') — 0 is falsy, so compression is skipped entirely
So the schema documents 1200, the shipped template sets 0, and the runtime honors 0. There is no code-level 1200 default anywhere.
Note this is specifically http.compressionThreshold. The unrelated storage.compressionThreshold (LMDB record compression) does have a real code default — (storage.pageSize || 4096) - 60 at resources/databases.ts:102 — which makes this easy to conflate when grepping.
Is compressionThreshold: 0 in the shipped config intentional? The docs fix depends entirely on the answer, and the two outcomes are very different:
If 0 is a bug in harper - Brotli compression has been silently off for every default install. That is the real finding here, and the fix belongs in static/defaultConfig.yaml. Our docs then need no change beyond possibly noting the versions affected.
If 0 is intentional - then harper's own schema description and examples are wrong too, and our four locations should say compression is disabled by default and must be explicitly enabled. In that case config-root.schema.json should be corrected alongside.
Either way one of the two harper locations is wrong, so this likely wants a companion harper issue; transferring or cross-linking is fine.
Why it matters beyond a wrong number
Two things downstream depend on this:
Anyone following our docs believes responses over 1200 bytes are compressed. If they are not, that is a real and invisible performance difference on a default install.
There is a latent crash gated behind this setting. contentTypes.ts:410-425 pipes serializeStream's return value into createBrotliCompress() whenever canCompress is true, but the application/x-msgpack handler returns a Buffer (not a stream) for a plain array. Accept: application/x-msgpack + Accept-Encoding: br + an array body would throw TypeError: stream.pipe is not a function. That is currently unreachable only because compression ships disabled - so if the default is "corrected" to 1200 without fixing the pipe path first, this becomes reachable the same day. Sequencing matters. Surfaced in docs(http): correct serializeStream return type - follow-up to #641 #655.
Suggested fix
Get a ruling from whoever owns static/defaultConfig.yaml on whether 0 is intended.
Fix harper's inconsistency (either the shipped default or the schema description + examples).
Update the four locations above to match, in one pass so they cannot disagree with each other.
Track the .pipe() normalization separately, and land it before any change that turns compression on by default.
What's wrong
The docs state that
http.compressionThresholddefaults to 1200 bytes, so Brotli response compression is on out of the box. Harper's shipped configuration sets it to 0, and the runtime treats 0 as "off" — so on a default install, Brotli response compression never happens.The root cause is not in this repo. Harper contradicts itself, and our docs faithfully mirror the half of it that isn't what actually ships.
Evidence (harper
origin/main)config-root.schema.json:25-31config-root.schema.json:774examplesblock:"compressionThreshold": 1200static/defaultConfig.yaml:4compressionThreshold: 0— this is what gets written into a new install's configvalidation/configValidator.ts:329compressionThreshold: number.optional()— no default injectedserver/serverHelpers/contentTypes.ts:362const COMPRESSION_THRESHOLD = envMgr.get(CONFIG_PARAMS.HTTP_COMPRESSIONTHRESHOLD)— no||fallback, so a configured 0 stays 0server/serverHelpers/contentTypes.ts:373canCompress = COMPRESSION_THRESHOLD && request.headers...includes('br')— 0 is falsy, so compression is skipped entirelySo the schema documents 1200, the shipped template sets 0, and the runtime honors 0. There is no code-level 1200 default anywhere.
Note this is specifically
http.compressionThreshold. The unrelatedstorage.compressionThreshold(LMDB record compression) does have a real code default —(storage.pageSize || 4096) - 60atresources/databases.ts:102— which makes this easy to conflate when grepping.Affected pages in this repo
reference/configuration/options.md:37- "Default:1200(bytes)"reference/http/configuration.md:111- thehttp.compressionThresholdsection, plus1200in examples at:123and:318reference/http/overview.md:104- "Compression applies when the response body exceeds the configuredcompressionThreshold(default 1200 bytes)"reference/configuration/operations.md:106-"compressionThreshold": 1200in a config response exampleThe question that has to be answered first
Is
compressionThreshold: 0in the shipped config intentional? The docs fix depends entirely on the answer, and the two outcomes are very different:static/defaultConfig.yaml. Our docs then need no change beyond possibly noting the versions affected.config-root.schema.jsonshould be corrected alongside.Either way one of the two harper locations is wrong, so this likely wants a companion harper issue; transferring or cross-linking is fine.
Why it matters beyond a wrong number
Two things downstream depend on this:
contentTypes.ts:410-425pipesserializeStream's return value intocreateBrotliCompress()whenevercanCompressis true, but theapplication/x-msgpackhandler returns aBuffer(not a stream) for a plain array.Accept: application/x-msgpack+Accept-Encoding: br+ an array body would throwTypeError: stream.pipe is not a function. That is currently unreachable only because compression ships disabled - so if the default is "corrected" to 1200 without fixing the pipe path first, this becomes reachable the same day. Sequencing matters. Surfaced in docs(http): correct serializeStream return type - follow-up to #641 #655.Suggested fix
static/defaultConfig.yamlon whether 0 is intended..pipe()normalization separately, and land it before any change that turns compression on by default.sent with Claude Opus 5