Skip to content

CI never compiles the Tauri crate, so app breakage surfaces at release time #53

Description

@Muawiya-contact

ci.yml runs clippy and tests for -p diskern-core -p diskern-cli only:

# Core + CLI only: building the Tauri crate needs webkitgtk, which CI
# for library tests doesn't need. The release workflow covers the app.

The reasoning is sound for keeping PRs fast, but it means nothing compiles app/src-tauri until someone pushes a v* tag. A change to diskern-core's public API that breaks commands.rs merges green and then fails the release build — at the worst possible moment, since the tag is already pushed.

app-frontend has the same shape of gap on the JS side, but it does at least run vite build.

Options, cheapest first:

  • cargo check -p diskern-app on ubuntu with the webkitgtk deps installed (the release workflow already has the apt line to copy)
  • only run it when app/** or crates/** changed, to keep doc-only PRs fast

.github/workflows/ci.yml:26

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    choreMaintenance, cleanup, toolingciCI workflows and release automationenhancementNew feature or requestgithub_actionsPull requests that update GitHub Actions codehelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions