Skip to content

No way to cancel a running scan #49

Description

@Muawiya-contact

ScanProgress has a cancel() method and scan() checks the flag on every entry, so the engine supports cancellation. Nothing exposes it.

start_scan creates the ScanProgress locally, keeps no handle anywhere the app can reach, and there's no cancel_scan command in invoke_handler. In the UI the scan button just goes disabled — pointing the app at a home directory means waiting it out or killing the app.

Needs a shared handle to the in-flight scan's ScanProgress (app state), a cancel_scan command, and a Cancel button next to the progress indicator. The GenomeError::Cancelled path already exists and should be shown as a normal outcome, not an error.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesthelp wantedExtra attention is neededjavascriptPull requests that update javascript coderustPull requests that update rust code

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions