Skip to content

hardening: replace eval-based callback execution in syslog autocomplete JS #260

Description

@somethingwithproof

Summary

Autocomplete callback currently executes callback text via eval().

Evidence

js/functions.js:593-595 in initSyslogAutocomplete():

if (onChange) {
  eval(onChange);
}

Risk

eval() increases client-side code execution risk and makes static security analysis harder.

Expected fix

Use function references or a whitelist/map of allowed callback names instead of eval().

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions